This is an archive of the discontinued LLVM Phabricator instance.

[mlir][doc] Fix the EBNF description of mlir syntax in language reference doc
ClosedPublic

Authored by zzz00yx on May 7 2023, 7:38 AM.

Details

Summary

According to the EBNF syntax described in the 'Common syntax' chapter, literal characters should be surrounded by backticks (`). However, in some sections of this document, single quotes (') are used instead. So, fix them.

Diff Detail

Event Timeline

zzz00yx created this revision.May 7 2023, 7:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 7:38 AM
zzz00yx requested review of this revision.May 7 2023, 7:38 AM

At line 705 and line 837, the single quotes are removed but not be replaced.

BTW, if this patch Looks Good To You, could you please help me land it to the repo, because I have no commit access.
My information: Yan Xin <zzz00yx@gmail.com>

mehdi_amini accepted this revision.May 10 2023, 6:44 AM
This revision is now accepted and ready to land.May 10 2023, 6:44 AM

Thanks for your review, I have no commit access, could you help me land it to the repo please?