This is an archive of the discontinued LLVM Phabricator instance.

Differential D150052

[mlir][linalg] Fix depthwise_conv_3d_ndhwc_dhwc op definition
AcceptedPublic

Authored by kon72 on May 6 2023, 4:14 PM.

Details

Reviewers
ftynse
nicolasvasilache
Summary

Adds missing channel dimension to the output tensor definition.

Diff Detail

Event Timeline

kon72 created this revision.May 6 2023, 4:14 PM
Herald added a reviewer: ftynse. · View Herald TranscriptMay 6 2023, 4:14 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, bzcheeseman and 23 others. · View Herald Transcript
kon72 requested review of this revision.May 6 2023, 4:14 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 6 2023, 4:14 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B230451: Diff 520128.May 6 2023, 4:29 PM
nicolasvasilache accepted this revision.May 7 2023, 12:18 AM
This revision is now accepted and ready to land.May 7 2023, 12:18 AM
kon72 updated this revision to Diff 522459.May 16 2023, 12:16 AM

Remove typo fixes

Herald added a subscriber: hanchung. · View Herald TranscriptMay 16 2023, 12:16 AM
Harbormaster completed remote builds in B232211: Diff 522459.May 16 2023, 12:42 AM

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Linalg/
IR/
2 lines
python/
mlir/
dialects/
linalg/
opdsl/
ops/
1 line

Diff 522459

mlir/include/mlir/Dialect/Linalg/IR/LinalgNamedStructuredOps.yaml

Show First 20 Lines • Show All 3,016 Lines • ▼ Show 20 Lines - !LinalgOperandDefConfig
type_var: T2 type_var: T2
shape_map: affine_map<()[s0, s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, s12, shape_map: affine_map<()[s0, s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, s12,
s13] -> (s3, s7, s11, s13)> s13] -> (s3, s7, s11, s13)>
- !LinalgOperandDefConfig - !LinalgOperandDefConfig
name: O name: O
kind: output_tensor kind: output_tensor
type_var: U type_var: U
shape_map: affine_map<()[s0, s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, s12, shape_map: affine_map<()[s0, s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, s12,
s13] -> (s0, s1, s5, s9)> s13] -> (s0, s1, s5, s9, s13)>
- !LinalgOperandDefConfig - !LinalgOperandDefConfig
name: strides name: strides
kind: index_attr kind: index_attr
index_attr_map: affine_map<()[s0, s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, index_attr_map: affine_map<()[s0, s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11,
s12, s13] -> (s2, s6, s10)> s12, s13] -> (s2, s6, s10)>
default_indices: default_indices:
- 1 - 1
- 1 - 1
▲ Show 20 Lines • Show All 1,692 Lines • Show Last 20 Lines

mlir/python/mlir/dialects/linalg/opdsl/ops/core_named_ops.py

Show First 20 Lines • Show All 687 Lines • ▼ Show 20 Linesdef depthwise_conv_3d_ndhwc_dhwc(I=TensorDef(T1, S.N, S.OD * S.SD + S.KD * S.DD,
S.OH * S.SH + S.KH * S.DH, S.OH * S.SH + S.KH * S.DH,
S.OW * S.SW + S.KW * S.DW, S.IC), S.OW * S.SW + S.KW * S.DW, S.IC),
K=TensorDef(T2, S.KD, S.KH, S.KW, S.IC), K=TensorDef(T2, S.KD, S.KH, S.KW, S.IC),
O=TensorDef(U, O=TensorDef(U,
S.N, S.N,
S.OD, S.OD,
S.OH, S.OH,
S.OW, S.OW,
S.IC,
output=True), output=True),
strides=IndexAttrDef(S.SD, strides=IndexAttrDef(S.SD,
S.SH, S.SH,
S.SW, S.SW,
default=[1, 1, 1]), default=[1, 1, 1]),
dilations=IndexAttrDef(S.DD, dilations=IndexAttrDef(S.DD,
S.DH, S.DH,
S.DW, S.DW,
▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines