[lldb,NetBSD] getValue => operator* for Optional migration

[nikicoon]

Summary

fixes https://github.com/llvm/llvm-project/issues/62561.
similar to https://github.com/llvm/llvm-project/issues/60401 on FreeBSD

[mgorny]

Thanks! Do you have commit access or do you need me to push it for you? If the latter, could you please upload a git format-patch patch (e.g. using "Upload File") here, so I could preserve authorship easily?

[nikicoon]

In D150032#4324239, @mgorny wrote:

Thanks! Do you have commit access or do you need me to push it for you? If the latter, could you please upload a git format-patch patch (e.g. using "Upload File") here, so I could preserve authorship easily?

Thanks. I do not have commit access, please push it for me. The git format-patch was just added.

[mgorny]

You actually have to attach it as a file (or send to me, i.e. mgorny AT gentoo.org) because Phabricator is a PoS that converts patches to useless diffs.

[emaste]

because Phabricator is a PoS that converts patches to useless diffs

FWIW the Phorge folks have taken an interest in these sorts of complaints brought by the FreeBSD community, e.g. https://we.phorge.it/Q46, https://we.phorge.it/T15249, https://we.phorge.it/T15096, and https://we.phorge.it/T15364

[nikicoon]

In D150032#4327156, @emaste wrote:

because Phabricator is a PoS that converts patches to useless diffs

FWIW the Phorge folks have taken an interest in these sorts of complaints brought by the FreeBSD community, e.g. https://we.phorge.it/Q46, https://we.phorge.it/T15249, https://we.phorge.it/T15096, and https://we.phorge.it/T15364

we have some (iirc not that many) build unbreaking patches in pkgsrc for various llvm projects which I plan on upstreaming if possible, so that we just have to rely on build-system adjustments for pkgsrc specific settings.

lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

NativeRegisterContextNetBSD_x86_64::ReadRegister(const RegisterInfo *reg_info,
   if (!opt_set) {
     // This is likely an internal register for lldb use only and should not be
     // directly queried.
     error.SetErrorStringWithFormat("register \"%s\" is in unrecognized set",
                                    reg_info->name);
     return error;
   }
 
-  RegSetKind set = opt_set.getValue();
+  RegSetKind set = *opt_set;
   error = ReadRegisterSet(set);
   if (error.Fail())
     return error;
 
   switch (set) {
   case GPRegSet:
   case FPRegSet:
   case DBRegSet: {
Status NativeRegisterContextNetBSD_x86_64::WriteRegister(
   if (!opt_set) {
     // This is likely an internal register for lldb use only and should not be
     // directly queried.
     error.SetErrorStringWithFormat("register \"%s\" is in unrecognized set",
                                    reg_info->name);
     return error;
   }
 
-  RegSetKind set = opt_set.getValue();
+  RegSetKind set = *opt_set;
   uint64_t new_xstate_bv = 0;
 
   error = ReadRegisterSet(set);
   if (error.Fail())
     return error;
 
   switch (set) {
   case GPRegSet: