[mlir][openacc] Update acc.data verifier for dataOperands

[clementval]

Summary

Data operands associated with acc.data should comes
from acc data entry/exit operations or acc.getdeviceptr.

[razvanlupusoru]

LGTM

mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp

 
 LogicalResult acc::DataOp::verify() {
   // 2.6.5. Data Construct restriction
   // At least one copy, copyin, copyout, create, no_create, present, deviceptr,
   // attach, or default clause must appear on a data construct.
   if (getOperands().empty() && !getDefaultAttr())
     return emitError("at least one operand or the default attribute "
                      "must appear on the data operation");
+
+  for (mlir::Value operand : getDataClauseOperands())
+    if (!mlir::isa<acc::AttachOp, acc::CopyinOp, acc::CopyoutOp, acc::CreateOp,
+                   acc::DeleteOp, acc::DetachOp, acc::DevicePtrOp,
+                   acc::GetDevicePtrOp, acc::NoCreateOp, acc::PresentOp>(
+            operand.getDefiningOp()))
+      return emitError("expect data entry/exit operation or acc.getdeviceptr "
+                       "as defining op");
+
   return success();
 }
 
 unsigned DataOp::getNumDataOperands() {
   return getCopyOperands().size() + getCopyinOperands().size() +
          getCopyinReadonlyOperands().size() + getCopyoutOperands().size() +
          getCopyoutZeroOperands().size() + getCreateOperands().size() +
          getCreateZeroOperands().size() + getNoCreateOperands().size() +

mlir/test/Dialect/OpenACC/invalid.mlir

 
 // expected-error@+1 {{at least one operand or the default attribute must appear on the data operation}}
 acc.data {
   acc.yield
 }
 
 // -----
 
+%value = memref.alloc() : memref<10xf32>
+// expected-error@+1 {{expect data entry/exit operation or acc.getdeviceptr as defining op}}
+acc.data dataOperands(%value : memref<10xf32>) {
+  acc.yield
+}
+
+// -----
+
 // expected-error@+1 {{at least one value must be present in hostOperands or deviceOperands}}
 acc.update
 
 // -----
 
 %cst = arith.constant 1 : index
 %value = memref.alloc() : memref<10xf32>
 // expected-error@+1 {{wait_devnum cannot appear without waitOperands}}