[mlir][transform] Clean up test-interpreter.mlir test

[springerm]

Summary

Remove redundant CHECK lines. This test does not use FileCheck.

[ftynse]

It wasn't missing, it was never necessary in this test. Specifically, the sequence doesn't do anything with the function declaration here so there is no point in checking that it is still present.

[springerm]

There is a CHECK-NOT in line 259, should I remove it instead?

[springerm]

(The CHECK-LABEL was necessary so that the call @bar of the test afterwards is not matched by the CHECK-NOT.)

[ftynse]

Yes, let's drop that, it isn't really necessary. We see that the transformation was applied from the remark it emits. And the point of that test is not crashing because there is no second attempt at erasing the op.

[springerm]

address comments

mlir/test/Dialect/Transform/test-interpreter.mlir

pdl.pattern @const : benefit(1) {
     %r = pdl.types
     %0 = pdl.operation "arith.constant" -> (%r : !pdl.range<type>)
     pdl.rewrite %0 with "transform.dialect"
   }
 
   transform.sequence %arg0 : !pdl.operation failures(propagate) {
   ^bb1(%arg1: !pdl.operation):
     %f = pdl_match @const in %arg1 : (!pdl.operation) -> !pdl.operation
-    // CHECK: %{{.+}} = get_closest_isolated_parent %{{.+}}
     %m = get_closest_isolated_parent %f : (!pdl.operation) -> !pdl.operation
     test_print_remark_at_operand %m, "parent function" : !pdl.operation
   }
 }
 
 // -----
 
 func.func @foo() {
^bb1(%arg1: !pdl.operation):
     }
   }
 }
 
 // -----
 
 func.func private @bar()
 
-// CHECK-LABEL: @erase_call
 func.func @erase_call() {
-  // CHECK-NOT: call @bar
   call @bar() : () -> ()
   return
 }
 
 transform.with_pdl_patterns {
 ^bb0(%arg0: !pdl.operation):
   pdl.pattern @match_call : benefit(1) {
     %0 = pdl.operands