[libc] Split out FPExceptMatcher from the FP utils

[jhuber6]

Summary

The FPEceptMatcher.cpp file uses system utilities and includes C++
libraries. This patch pulls it out of the main FPTestHelpers target so
we can exclude it from hermetic only tests.

Depends on D149705

[sivachandra]

libc/test/src/CMakeLists.txt

30 ↗

(On Diff #519055)

Instead of adding LibcFPExceptionHelpers here for all math tests, WDYT of adding to LINK_LIBRARIES of the two tests which actually use this?

[jhuber6]

libc/test/src/CMakeLists.txt

30 ↗

(On Diff #519055)

Works for me.

[jhuber6]

Change to explicit link libraries

libc/test/UnitTest/CMakeLists.txt

add_header_library(
   StringUtils.h
   DEPENDS
     libc.src.__support.CPP.string
     libc.src.__support.CPP.type_traits
 )
 
 add_library(
   LibcFPTestHelpers
-  FPExceptMatcher.cpp
-  FPExceptMatcher.h
   FPMatcher.h
   RoundingModeUtils.cpp
   RoundingModeUtils.h
 )
 add_dependencies(
   LibcFPTestHelpers
   LibcUnitTest
   libc.test.UnitTest.string_utils
   libc.src.__support.FPUtil.fp_bits
   libc.src.__support.FPUtil.fenv_impl
   libc.test.UnitTest.string_utils
 )
+add_library(
+  LibcFPExceptionHelpers
+  FPExceptMatcher.cpp
+  FPExceptMatcher.h
+)
+add_dependencies(
+  LibcFPExceptionHelpers
+  LibcUnitTest
+  libc.src.__support.FPUtil.fp_bits
+  libc.src.__support.FPUtil.fenv_impl
+)
 
 add_library(
   LibcMemoryHelpers
   MemoryMatcher.h
   MemoryMatcher.cpp
 )
 add_dependencies(
   LibcMemoryHelpers

 add_dependencies(
   LibcScanfHelpers
   LibcUnitTest
   libc.src.__support.FPUtil.fp_bits
   libc.src.stdio.scanf_core.core_structs
   libc.test.UnitTest.string_utils
 )
 
-foreach(lib LibcFPTestHelpers LibcMemoryHelpers LibcPrintfHelpers LibcScanfHelpers)
+foreach(lib LibcFPTestHelpers LibcFPExceptionHelpers LibcMemoryHelpers 
+            LibcPrintfHelpers LibcScanfHelpers)
   target_include_directories(${lib} PUBLIC ${LIBC_SOURCE_DIR})
   target_compile_options(${lib} PRIVATE -fno-exceptions -fno-rtti)
   target_link_libraries(${lib} LibcUnitTest)
 endforeach()

libc/test/src/fenv/CMakeLists.txt

add_fp_unittest(
     SRCS
       enabled_exceptions_test.cpp
     DEPENDS
       libc.include.signal
       libc.src.fenv.feclearexcept
       libc.src.fenv.feraiseexcept
       libc.src.fenv.fetestexcept
       libc.src.__support.FPUtil.fenv_impl
+    LINK_LIBRARIES
+      LibcFPExceptionHelpers
   )
 
   add_fp_unittest(
     feholdexcept_test
     SUITE
       libc_fenv_unittests
     SRCS
       feholdexcept_test.cpp
     DEPENDS
       libc.include.fenv
       libc.src.fenv.feholdexcept
       libc.src.__support.FPUtil.fenv_impl
+    LINK_LIBRARIES
+      LibcFPExceptionHelpers
   )
 endif()