[Coverity] Fix unchecked return value, NFC

[pengfei]

Summary

The ReversePredicate should have made sure the reverse predicate is
supported by target, but the check comes from early function and might
be invalid by any mistake. So it's better to double confirm it here.

[barannikov88]

llvm/lib/CodeGen/EarlyIfConversion.cpp

347

This is wrong. Assert will be removed in release mode, along with the call.

[pengfei]

Address review comment.

llvm/lib/CodeGen/EarlyIfConversion.cpp

347

Good catch, thanks!

[barannikov88]

BTW it may be worth annotating this method (and maybe others) with [[nodiscard]].

[pengfei]

In D149586#4311474, @barannikov88 wrote:

BTW it may be worth annotating this method (and maybe others) with [[nodiscard]].

Thanks for the suggestion! That sounds a good idea to me, but I took a look at current LLVM code base and didn't find an instance that using [[nodiscard]] on virtual functions. A simply googling pointed me a discussion about GCC bug.
No sure if it is the reason that we haven't used it. Anyway, let's not do it for now.

llvm/lib/CodeGen/EarlyIfConversion.cpp

if (!InstrDependenciesAllowIfConv(&(*I)))
       return false;
   }
   return true;
 }
 
 // Apply predicate to all instructions in the machine block.
 void SSAIfConv::PredicateBlock(MachineBasicBlock *MBB, bool ReversePredicate) {
   auto Condition = Cond;
-  if (ReversePredicate)
-    TII->reverseBranchCondition(Condition);
+  if (ReversePredicate) {
+    bool CanRevCond = !TII->reverseBranchCondition(Condition);
+    assert(CanRevCond && "Reversed predicate is not supported");
+    (void)CanRevCond;
+  }
   // Terminators don't need to be predicated as they will be removed.
   for (MachineBasicBlock::iterator I = MBB->begin(),
                                    E = MBB->getFirstTerminator();
        I != E; ++I) {
     if (I->isDebugInstr())
       continue;
     TII->PredicateInstruction(*I, Condition);
   }