Just so we can make future changes with update_llc_test_checks.py
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
4 | These need cleaning up - duplicate RUN, and I think you can have a common CHECK prefix as well ; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s --check-prefixes=CHECK,V7 ; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s --check-prefixes=CHECK,V8 | |
87 | remove these |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
8 | Where has the V7 coverage gone? |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
8 |
I think there is a bug somewhere. -mtriple=arm-apple-darwin simply does not generate automatic checks. Guess drop this one from regen and update it by hand in the known-non-zero patch? |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
8 | Sure, or update it manually here (remove the extra RUN etc.) - as long as you remove the NOTE from the top then it should be fine. |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
8 | I wonder if the triple should be armv7-apple-darwin which has an override in get_run_handler llvm/utils/UpdateTestChecks/asm.py. That override defines the regular expression to convert between IR function name and assembly function name. |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
8 | Probably - in which case we need to add the original arm-apple-darwin RUN line back again to retain coverage and we still can't auto generate it :) |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
4 | There's nothing darwin specific - so I think using this should be fine: ; RUN: llc < %s -mtriple=arm-none | FileCheck %s ; RUN: llc < %s -mtriple=armv7-none-linux-gnueabi | FileCheck %s --check-prefixes=V78,V7 ; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s -check-prefixes=V78,V8 @dmgreen Any comments? |
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll | ||
---|---|---|
4 | Yeah, that sounds OK to me. |
These need cleaning up - duplicate RUN, and I think you can have a common CHECK prefix as well