This is an archive of the discontinued LLVM Phabricator instance.

[TargetLowering] Stop passing an ISD::CondCode to isOperationLegalOrCustom.
ClosedPublic

Authored by craig.topper on Apr 29 2023, 1:21 PM.

Details

Summary

ISD::CondCode is a separate num space from opcodes. isOperationLegalOrCustom
should take an opcode.

Diff Detail

Event Timeline

craig.topper created this revision.Apr 29 2023, 1:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 1:21 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
craig.topper requested review of this revision.Apr 29 2023, 1:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 1:21 PM
barannikov88 accepted this revision.Apr 29 2023, 1:55 PM
barannikov88 added a subscriber: barannikov88.
barannikov88 added inline comments.
llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
6706

Should this check SETCCVT instead? SETEQ is created below with this type.

This revision is now accepted and ready to land.Apr 29 2023, 1:55 PM