Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
The test cases would probably be simpler if this were using LICM.
llvm/test/Analysis/ValueTracking/speculate-div.ll | ||
---|---|---|
2 ↗ | (On Diff #517806) | Should have mentioned this earlier, but please don't put tests into llvm/test/Analysis/ValueTracking, unless they use special analysis printers. Instead put them into the pass being tested, here llvm/test/Transforms/SimplifyCFG. |
7 ↗ | (On Diff #517806) | The function attributes shouldn't be needed. |
Comment Actions
What do you think about this test structure? https://llvm.godbolt.org/z/nMxMGoz1r Seems clearer to me than going through speculative hoisting.
Comment Actions
Sure, where would that test belong? simplifycfg still?
Edit: putting in Transform/LICM.