Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D149343

[CMake] add_tablegen: Rename host tablegen to `${target}-host"
ClosedPublic
Actions

Authored by chapuni on Apr 27 2023, 6:37 AM.

Details

Reviewers
mstorsjo
Commits
rG4071dbb6b9ce: [CMake] add_tablegen: Rename host tablegen to `${target}-host"
Summary

Since llvm-min-tblgen has been introduced, llvm-min-tblgen-host
would make more sense than LLVM_HEADERS-tablegen-host.

Depends on D146352

Diff Detail

Event Timeline

chapuni created this revision.Apr 27 2023, 6:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 6:37 AM
Herald added a subscriber: ekilmer. · View Herald Transcript
chapuni requested review of this revision.Apr 27 2023, 6:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 6:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
chapuni added a reviewer: mstorsjo.Apr 27 2023, 6:39 AM
chapuni mentioned this in D146352: Introduce `llvm-min-tblgen` to build public header files.
Harbormaster completed remote builds in B228544: Diff 517541.Apr 27 2023, 7:10 AM
mstorsjo accepted this revision.Apr 27 2023, 7:20 AM

LGTM, although the commit message is a bit cryptic. What about:

This is a pure refactoring and simplification, allowing decoupling ${target} from ${project} in the future.

This revision is now accepted and ready to land.Apr 27 2023, 7:20 AM
This revision was landed with ongoing or failed builds.May 1 2023, 7:36 PM
Closed by commit rG4071dbb6b9ce: [CMake] add_tablegen: Rename host tablegen to `${target}-host" (authored by chapuni). · Explain Why
This revision was automatically updated to reflect the committed changes.
chapuni added a commit: rG4071dbb6b9ce: [CMake] add_tablegen: Rename host tablegen to `${target}-host".

Revision Contents
Changeset List

PathSize
llvm/
cmake/
modules/
4 lines

Diff 518624

View Options

llvm/cmake/modules/TableGen.cmake

Loading...