[lldb] Create a way to force remove commands

[wallace]

Summary

Some LLDB set ups need to hide certain commands for security reasons, so I'm adding a flag that allows removing non-user commands.

[bzcheeseman]

lldb/include/lldb/Interpreter/CommandInterpreter.h

329

should force default to false?

[rriddle]

LGTM with comment addressed, and white space changes dropped.

[wallace]

remove whitespace changes

[jingham]

This was added without a test. Can you add a test.

[wallace]

Sure

[jingham]

This also seems a bit Quixotic to me. Unless you are also planning to remove the script command, there's nothing you can do in the command line that you can't do with the SB API so you aren't actually removing any functionality, just making it slightly less convenient.

[jingham]

In D149312#4302449, @wallace wrote:

Sure

You can probably just add something to TestCommandDelete.py.

[wallace]

-> https://reviews.llvm.org/D149379

[wallace]

@jingham, in my use case, I'm exposing a minified LLDB client remotely, so the user won't have access to script command nor the SB API.

lldb/include/lldb/Interpreter/CommandInterpreter.h

public:
   CommandObjectMultiword *VerifyUserMultiwordCmdPath(Args &path,
                                                      bool leaf_is_command,
                                                      Status &result);
 
   CommandAlias *AddAlias(llvm::StringRef alias_name,
                          lldb::CommandObjectSP &command_obj_sp,
                          llvm::StringRef args_string = llvm::StringRef());
 
-  // Remove a command if it is removable (python or regex command)
-  bool RemoveCommand(llvm::StringRef cmd);
+  /// Remove a command if it is removable (python or regex command). If \b force
+  /// is provided, the command is removed regardless of its removable status.
+  bool RemoveCommand(llvm::StringRef cmd, bool force = false);
 
   bool RemoveAlias(llvm::StringRef alias_name);
 
   bool GetAliasFullName(llvm::StringRef cmd, std::string &full_name) const;
 
   bool RemoveUserMultiword(llvm::StringRef multiword_name);
 
   // Do we want to allow top-level user multiword commands to be deleted?

lldb/source/Interpreter/CommandInterpreter.cpp

bool CommandInterpreter::RemoveAlias(llvm::StringRef alias_name) {
   auto pos = m_alias_dict.find(std::string(alias_name));
   if (pos != m_alias_dict.end()) {
     m_alias_dict.erase(pos);
     return true;
   }
   return false;
 }
 
-bool CommandInterpreter::RemoveCommand(llvm::StringRef cmd) {
+bool CommandInterpreter::RemoveCommand(llvm::StringRef cmd, bool force) {
   auto pos = m_command_dict.find(std::string(cmd));
   if (pos != m_command_dict.end()) {
-    if (pos->second->IsRemovable()) {
-      // Only regular expression objects or python commands are removable
+    if (force || pos->second->IsRemovable()) {
+      // Only regular expression objects or python commands are removable under
+      // normal circumstances.
       m_command_dict.erase(pos);
       return true;
     }
   }
   return false;
 }
 
 bool CommandInterpreter::RemoveUser(llvm::StringRef user_name) {