This is an archive of the discontinued LLVM Phabricator instance.

[clang][Interp] Emit proper diagnostic when comparing unrelated pointers
ClosedPublic

Authored by tbaeder on Apr 25 2023, 10:56 AM.

Details

Summary

Also adds toDiagnosticString() to Pointer so we can use that when emitting the diagnostic.

Diff Detail

Event Timeline

tbaeder created this revision.Apr 25 2023, 10:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 10:56 AM
tbaeder requested review of this revision.Apr 25 2023, 10:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2023, 10:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Apr 26 2023, 4:41 AM

Meh, turns out (void*)&s.a; is a bitcast, so can't push this yet.

This revision was landed with ongoing or failed builds.Jul 28 2023, 4:24 AM
This revision was automatically updated to reflect the committed changes.