Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[LLD][COFF] Print object file name for unsupported directives
ClosedPublic

Authored by alvinhochun on Apr 23 2023, 9:15 AM.

Diff Detail

Event Timeline

alvinhochun created this revision.Apr 23 2023, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 9:15 AM
alvinhochun requested review of this revision.Apr 23 2023, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 9:15 AM

Run clang-format

mstorsjo accepted this revision.Apr 23 2023, 12:14 PM

LGTM, thanks!

lld/test/COFF/directives-unsupported.s
5

Curious; why the --ignore-case here?

This revision is now accepted and ready to land.Apr 23 2023, 12:14 PM
alvinhochun added inline comments.Apr 24 2023, 1:45 AM
lld/test/COFF/directives-unsupported.s
5

A leftover from another test that I missed. I can remove it when committing.

hans accepted this revision.Apr 24 2023, 4:00 AM