[mlir][tosa] Call TosaInferShapes pass in addTosaToLinalgPasses

[AviadCo]

Summary

This pass is useful to legalize rankless and dynamic shapes towards static using operands' shapes & types.

[jpienaar]

Is the ordering after decomposition on purpose?

[AviadCo]

In D148998#4298532, @jpienaar wrote:

Is the ordering after decomposition on purpose?

No, do you think it should be before Decomposition to have more affect?

[jpienaar]

I haven't tested, that just stood out to me. Test, if it has no effect, then leave as is (i could see argument both ways and I think it should matter, or rather where it matters it is covering some gaps).

[AviadCo]

In D148998#4320869, @jpienaar wrote:

I haven't tested, that just stood out to me. Test, if it has no effect, then leave as is (i could see argument both ways and I think it should matter, or rather where it matters it is covering some gaps).

Well, currently no one uses this funciton directly in this repository, I am using it from another repository and I am not pretty sure the ordering has an affect, I will land it as is for now.

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgPass.cpp

 
 void mlir::tosa::addTosaToLinalgPasses(OpPassManager &pm,
                                        bool disableTosaDecompositions) {
   // Optional decompositions are designed to benefit linalg.
   if (!disableTosaDecompositions)
     pm.addNestedPass<func::FuncOp>(tosa::createTosaOptionalDecompositions());
   pm.addNestedPass<func::FuncOp>(createCanonicalizerPass());
 
+  pm.addNestedPass<func::FuncOp>(tosa::createTosaInferShapesPass());
   pm.addNestedPass<func::FuncOp>(tosa::createTosaMakeBroadcastablePass());
   pm.addNestedPass<func::FuncOp>(tosa::createTosaToLinalgNamed());
   pm.addNestedPass<func::FuncOp>(createCanonicalizerPass());
   // TODO: Remove pass that operates on const tensor and enable optionality
   pm.addNestedPass<func::FuncOp>(tosa::createTosaLayerwiseConstantFoldPass());
   pm.addNestedPass<func::FuncOp>(tosa::createTosaMakeBroadcastablePass());
   pm.addNestedPass<func::FuncOp>(tosa::createTosaValidationPass());
   pm.addNestedPass<func::FuncOp>(tosa::createTosaToLinalg());
 }