This is an archive of the discontinued LLVM Phabricator instance.

Differential D148807

[llvm-exegesis][AArch64] Only run tests on aarch64 hosts
ClosedPublic

Authored by tstellar on Apr 20 2023, 8:15 AM.

Details

Reviewers
kpdev42
gchatelet
courbet
Commits
rGbeaf46a42d85: [llvm-exegesis][AArch64] Only run tests on aarch64 hosts
Summary

The add-return.s test is failing on s390x.

See also e30ce634f75c01cc8784cb0c4972c42987178c1d.

Diff Detail

Event Timeline

tstellar created this revision.Apr 20 2023, 8:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 8:15 AM
Herald added subscribers: mstojanovic, kristof.beyls. · View Herald Transcript
tstellar requested review of this revision.Apr 20 2023, 8:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 8:15 AM
Herald added a subscriber: courbet. · View Herald Transcript
Harbormaster completed remote builds in B226883: Diff 515341.Apr 20 2023, 8:46 AM
kpdev42 added a comment.Apr 21 2023, 5:59 AM

Sorry for delay, this patch https://reviews.llvm.org/D148921 should fix the tests on s390x and make it possible to run tests that not involve code execution on any platform. The issue seems to be because llvm-exegesis was initially intended to only generate code for host CPU, so even after --mtriple option was introduced it used MCJIT for fetching assembled_snippet for historical reasons.

kpdev42 mentioned this in D147699: [llvm-exegesis][AArch64] Add return statement at the end of the snippet correctly.Apr 21 2023, 6:07 AM
courbet accepted this revision.Apr 21 2023, 6:34 AM

Let's submit this quick fix first and we can re-enable it after your other patch.

This revision is now accepted and ready to land.Apr 21 2023, 6:34 AM
This revision was landed with ongoing or failed builds.Apr 21 2023, 7:18 AM
Closed by commit rGbeaf46a42d85: [llvm-exegesis][AArch64] Only run tests on aarch64 hosts (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rGbeaf46a42d85: [llvm-exegesis][AArch64] Only run tests on aarch64 hosts.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-exegesis/
AArch64/
3 lines

Diff 515723

llvm/test/tools/llvm-exegesis/AArch64/lit.local.cfg

if not ('AArch64' in config.root.targets): if not ('AArch64' in config.root.targets):
# We need support for AArch64. # We need support for AArch64.
config.unsupported = True config.unsupported = True
elif not ('aarch64' in config.root.host_triple):
# We need to be running on an PPC host.
config.unsupported = True