This is an archive of the discontinued LLVM Phabricator instance.

Differential D148781

[libc][math] Remove placeholder implementations of asin and pow.
ClosedPublic

Authored by lntue on Apr 19 2023, 10:04 PM.

Details

Reviewers
michaelrj
sivachandra
Commits
rGf79264b5f66f: [libc][math] Remove placeholder implementations of asin and pow.

Diff Detail

Event Timeline

lntue created this revision.Apr 19 2023, 10:04 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 19 2023, 10:04 PM
Herald added subscribers: luke, frasercrmck, ecnelises and 21 others. · View Herald Transcript
lntue requested review of this revision.Apr 19 2023, 10:04 PM
Herald added a subscriber: • pcwang-thead. · View Herald TranscriptApr 19 2023, 10:04 PM
sivachandra accepted this revision.Apr 19 2023, 10:05 PM
sivachandra added inline comments.
libc/spec/stdc.td
484 ↗(On Diff #515217)

No harm in keeping the spec in place.

This revision is now accepted and ready to land.Apr 19 2023, 10:05 PM
Harbormaster completed remote builds in B226793: Diff 515217.Apr 19 2023, 10:10 PM
lntue updated this revision to Diff 515220.Apr 19 2023, 10:19 PM

Keep function specs in place.

lntue marked an inline comment as done.Apr 19 2023, 10:20 PM
Harbormaster completed remote builds in B226796: Diff 515220.Apr 19 2023, 10:26 PM
Closed by commit rGf79264b5f66f: [libc][math] Remove placeholder implementations of asin and pow. (authored by lntue). · Explain WhyApr 19 2023, 10:28 PM
This revision was automatically updated to reflect the committed changes.
lntue added a commit: rGf79264b5f66f: [libc][math] Remove placeholder implementations of asin and pow..

Revision Contents

PathSize
libc/
config/
linux/
aarch64/
2 lines
riscv64/
2 lines
x86_64/
2 lines
windows/
2 lines
src/
math/
3 lines
generic/
25 lines
test/
src/
math/
24 lines

Diff 515221

libc/config/linux/aarch64/entrypoints.txt

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.fesetround libc.src.fenv.fesetround
libc.src.fenv.feraiseexcept libc.src.fenv.feraiseexcept
libc.src.fenv.fetestexcept libc.src.fenv.fetestexcept
libc.src.fenv.feupdateenv libc.src.fenv.feupdateenv
# math.h entrypoints # math.h entrypoints
libc.src.math.acosf libc.src.math.acosf
libc.src.math.acoshf libc.src.math.acoshf
libc.src.math.asin
libc.src.math.asinf libc.src.math.asinf
libc.src.math.asinhf libc.src.math.asinhf
libc.src.math.atanf libc.src.math.atanf
libc.src.math.atanhf libc.src.math.atanhf
libc.src.math.copysign libc.src.math.copysign
libc.src.math.copysignf libc.src.math.copysignf
libc.src.math.copysignl libc.src.math.copysignl
libc.src.math.ceil libc.src.math.ceil
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.math.modff libc.src.math.modff
libc.src.math.modfl libc.src.math.modfl
libc.src.math.nearbyint libc.src.math.nearbyint
libc.src.math.nearbyintf libc.src.math.nearbyintf
libc.src.math.nearbyintl libc.src.math.nearbyintl
libc.src.math.nextafter libc.src.math.nextafter
libc.src.math.nextafterf libc.src.math.nextafterf
libc.src.math.nextafterl libc.src.math.nextafterl
libc.src.math.pow
libc.src.math.remainderf libc.src.math.remainderf
libc.src.math.remainder libc.src.math.remainder
libc.src.math.remainderl libc.src.math.remainderl
libc.src.math.remquof libc.src.math.remquof
libc.src.math.remquo libc.src.math.remquo
libc.src.math.remquol libc.src.math.remquol
libc.src.math.rint libc.src.math.rint
libc.src.math.rintf libc.src.math.rintf
▲ Show 20 Lines • Show All 173 Lines • Show Last 20 Lines

libc/config/linux/riscv64/entrypoints.txt

Show First 20 Lines • Show All 221 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.fesetround libc.src.fenv.fesetround
libc.src.fenv.feraiseexcept libc.src.fenv.feraiseexcept
libc.src.fenv.fetestexcept libc.src.fenv.fetestexcept
libc.src.fenv.feupdateenv libc.src.fenv.feupdateenv
# math.h entrypoints # math.h entrypoints
libc.src.math.acosf libc.src.math.acosf
libc.src.math.acoshf libc.src.math.acoshf
libc.src.math.asin
libc.src.math.asinf libc.src.math.asinf
libc.src.math.asinhf libc.src.math.asinhf
libc.src.math.atanf libc.src.math.atanf
libc.src.math.atanhf libc.src.math.atanhf
libc.src.math.copysign libc.src.math.copysign
libc.src.math.copysignf libc.src.math.copysignf
libc.src.math.copysignl libc.src.math.copysignl
libc.src.math.ceil libc.src.math.ceil
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.math.modff libc.src.math.modff
libc.src.math.modfl libc.src.math.modfl
libc.src.math.nearbyint libc.src.math.nearbyint
libc.src.math.nearbyintf libc.src.math.nearbyintf
libc.src.math.nearbyintl libc.src.math.nearbyintl
libc.src.math.nextafter libc.src.math.nextafter
libc.src.math.nextafterf libc.src.math.nextafterf
libc.src.math.nextafterl libc.src.math.nextafterl
libc.src.math.pow
libc.src.math.remainderf libc.src.math.remainderf
libc.src.math.remainder libc.src.math.remainder
libc.src.math.remainderl libc.src.math.remainderl
libc.src.math.remquof libc.src.math.remquof
libc.src.math.remquo libc.src.math.remquo
libc.src.math.remquol libc.src.math.remquol
libc.src.math.rint libc.src.math.rint
libc.src.math.rintf libc.src.math.rintf
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines

libc/config/linux/x86_64/entrypoints.txt

Show First 20 Lines • Show All 221 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.fesetround libc.src.fenv.fesetround
libc.src.fenv.feraiseexcept libc.src.fenv.feraiseexcept
libc.src.fenv.fetestexcept libc.src.fenv.fetestexcept
libc.src.fenv.feupdateenv libc.src.fenv.feupdateenv
# math.h entrypoints # math.h entrypoints
libc.src.math.acosf libc.src.math.acosf
libc.src.math.acoshf libc.src.math.acoshf
libc.src.math.asin
libc.src.math.asinf libc.src.math.asinf
libc.src.math.asinhf libc.src.math.asinhf
libc.src.math.atanf libc.src.math.atanf
libc.src.math.atanhf libc.src.math.atanhf
libc.src.math.copysign libc.src.math.copysign
libc.src.math.copysignf libc.src.math.copysignf
libc.src.math.copysignl libc.src.math.copysignl
libc.src.math.ceil libc.src.math.ceil
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.math.modff libc.src.math.modff
libc.src.math.modfl libc.src.math.modfl
libc.src.math.nearbyint libc.src.math.nearbyint
libc.src.math.nearbyintf libc.src.math.nearbyintf
libc.src.math.nearbyintl libc.src.math.nearbyintl
libc.src.math.nextafter libc.src.math.nextafter
libc.src.math.nextafterf libc.src.math.nextafterf
libc.src.math.nextafterl libc.src.math.nextafterl
libc.src.math.pow
libc.src.math.remainderf libc.src.math.remainderf
libc.src.math.remainder libc.src.math.remainder
libc.src.math.remainderl libc.src.math.remainderl
libc.src.math.remquof libc.src.math.remquof
libc.src.math.remquo libc.src.math.remquo
libc.src.math.remquol libc.src.math.remquol
libc.src.math.rint libc.src.math.rint
libc.src.math.rintf libc.src.math.rintf
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines

libc/config/windows/entrypoints.txt

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.fesetround libc.src.fenv.fesetround
libc.src.fenv.feraiseexcept libc.src.fenv.feraiseexcept
libc.src.fenv.fetestexcept libc.src.fenv.fetestexcept
libc.src.fenv.feupdateenv libc.src.fenv.feupdateenv
# math.h entrypoints # math.h entrypoints
libc.src.math.acosf libc.src.math.acosf
libc.src.math.acoshf libc.src.math.acoshf
libc.src.math.asin
libc.src.math.asinf libc.src.math.asinf
libc.src.math.asinhf libc.src.math.asinhf
libc.src.math.atanf libc.src.math.atanf
libc.src.math.atanhf libc.src.math.atanhf
libc.src.math.copysign libc.src.math.copysign
libc.src.math.copysignf libc.src.math.copysignf
libc.src.math.copysignl libc.src.math.copysignl
libc.src.math.ceil libc.src.math.ceil
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Linesset(TARGET_LIBM_ENTRYPOINTS
libc.src.math.modff libc.src.math.modff
libc.src.math.modfl libc.src.math.modfl
libc.src.math.nearbyint libc.src.math.nearbyint
libc.src.math.nearbyintf libc.src.math.nearbyintf
libc.src.math.nearbyintl libc.src.math.nearbyintl
libc.src.math.nextafter libc.src.math.nextafter
libc.src.math.nextafterf libc.src.math.nextafterf
libc.src.math.nextafterl libc.src.math.nextafterl
libc.src.math.pow
libc.src.math.remainderf libc.src.math.remainderf
libc.src.math.remainder libc.src.math.remainder
libc.src.math.remainderl libc.src.math.remainderl
libc.src.math.remquof libc.src.math.remquof
libc.src.math.remquo libc.src.math.remquo
libc.src.math.remquol libc.src.math.remquol
libc.src.math.rint libc.src.math.rint
libc.src.math.rintf libc.src.math.rintf
Show All 27 Lines

libc/src/math/CMakeLists.txt

Show All 37 Lines add_entrypoint_object(
HDRS HDRS
dummy_hdrs dummy_hdrs
) )
endfunction() endfunction()
add_math_entrypoint_object(acosf) add_math_entrypoint_object(acosf)
add_math_entrypoint_object(acoshf) add_math_entrypoint_object(acoshf)
add_math_entrypoint_object(asin)
add_math_entrypoint_object(asinf) add_math_entrypoint_object(asinf)
add_math_entrypoint_object(asinhf) add_math_entrypoint_object(asinhf)
add_math_entrypoint_object(atanf) add_math_entrypoint_object(atanf)
add_math_entrypoint_object(atanhf) add_math_entrypoint_object(atanhf)
add_math_entrypoint_object(ceil) add_math_entrypoint_object(ceil)
▲ Show 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
add_math_entrypoint_object(nearbyint) add_math_entrypoint_object(nearbyint)
add_math_entrypoint_object(nearbyintf) add_math_entrypoint_object(nearbyintf)
add_math_entrypoint_object(nearbyintl) add_math_entrypoint_object(nearbyintl)
add_math_entrypoint_object(nextafter) add_math_entrypoint_object(nextafter)
add_math_entrypoint_object(nextafterf) add_math_entrypoint_object(nextafterf)
add_math_entrypoint_object(nextafterl) add_math_entrypoint_object(nextafterl)
add_math_entrypoint_object(pow)
add_math_entrypoint_object(remainder) add_math_entrypoint_object(remainder)
add_math_entrypoint_object(remainderf) add_math_entrypoint_object(remainderf)
add_math_entrypoint_object(remainderl) add_math_entrypoint_object(remainderl)
add_math_entrypoint_object(remquo) add_math_entrypoint_object(remquo)
add_math_entrypoint_object(remquof) add_math_entrypoint_object(remquof)
add_math_entrypoint_object(remquol) add_math_entrypoint_object(remquol)
Show All 29 Lines

libc/src/math/asin.h

  • This file was deleted.
//===-- Implementation header for asin --------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_MATH_ASIN_H
#define LLVM_LIBC_SRC_MATH_ASIN_H
namespace __llvm_libc {
double asin(double x);
} // namespace __llvm_libc
#endif // LLVM_LIBC_SRC_MATH_ASIN_H

libc/src/math/generic/CMakeLists.txt

Show First 20 Lines • Show All 1,378 Lines • ▼ Show 20 Lines DEPENDS
libc.src.__support.FPUtil.sqrt libc.src.__support.FPUtil.sqrt
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
.inv_trigf_utils .inv_trigf_utils
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
) )
add_entrypoint_object( add_entrypoint_object(
asin
SRCS
asin.cpp
HDRS
../asin.h
DEPENDS
.asinf
COMPILE_OPTIONS
-O3
)
add_entrypoint_object(
acosf acosf
SRCS SRCS
acosf.cpp acosf.cpp
HDRS HDRS
../acosf.h ../acosf.h
DEPENDS DEPENDS
libc.src.__support.FPUtil.except_value_utils libc.src.__support.FPUtil.except_value_utils
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
Show All 17 Lines DEPENDS
.math_utils .math_utils
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.macros.optimization libc.src.__support.macros.optimization
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
) )
add_entrypoint_object( add_entrypoint_object(
pow
SRCS
pow.cpp
HDRS
../pow.h
DEPENDS
.expf
.logf
COMPILE_OPTIONS
-O3
)
add_entrypoint_object(
scalbn scalbn
SRCS SRCS
scalbn.cpp scalbn.cpp
HDRS HDRS
../scalbn.h ../scalbn.h
DEPENDS DEPENDS
libc.src.__support.FPUtil.manipulation_functions libc.src.__support.FPUtil.manipulation_functions
COMPILE_OPTIONS COMPILE_OPTIONS
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

libc/src/math/generic/asin.cpp

  • This file was deleted.
//===-- Double-precision asin function ------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/math/asin.h"
#include "src/math/asinf.h"
#include "src/__support/common.h"
namespace __llvm_libc {
LLVM_LIBC_FUNCTION(double, asin, (double x)) {
// Place-holder implementation for double precision asin function.
// TODO: Implement correctly rounded asin function for double precision.
return static_cast<double>(asinf(static_cast<float>(x)));
}
} // namespace __llvm_libc

libc/src/math/generic/pow.cpp

  • This file was deleted.
//===-- Implementation of pow function ------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/math/pow.h"
#include "src/math/expf.h"
#include "src/math/logf.h"
#include "src/__support/common.h"
namespace __llvm_libc {
LLVM_LIBC_FUNCTION(double, pow, (double x, double y)) {
// Place-holder implementation for double precision pow function.
// TODO: Implement correctly rounded pow function for double precision.
return static_cast<double>(
expf(static_cast<float>(y) * logf(static_cast<float>(x))));
}
} // namespace __llvm_libc

libc/src/math/pow.h

  • This file was deleted.
//===-- Implementation header for pow ---------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_MATH_POW_H
#define LLVM_LIBC_SRC_MATH_POW_H
namespace __llvm_libc {
double pow(double x, double y);
} // namespace __llvm_libc
#endif // LLVM_LIBC_SRC_MATH_POW_H

libc/test/src/math/CMakeLists.txt

Show First 20 Lines • Show All 1,477 Lines • ▼ Show 20 Lines SRCS
asinf_test.cpp asinf_test.cpp
DEPENDS DEPENDS
libc.src.errno.errno libc.src.errno.errno
libc.src.math.asinf libc.src.math.asinf
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
) )
add_fp_unittest( add_fp_unittest(
asin_test
NEED_MPFR
SUITE
libc_math_unittests
SRCS
asin_test.cpp
DEPENDS
libc.src.errno.errno
libc.src.math.asin
)
add_fp_unittest(
acosf_test acosf_test
NEED_MPFR NEED_MPFR
SUITE SUITE
libc_math_unittests libc_math_unittests
SRCS SRCS
acosf_test.cpp acosf_test.cpp
DEPENDS DEPENDS
libc.src.errno.errno libc.src.errno.errno
Show All 24 Linesadd_fp_unittest(
SRCS SRCS
inv_trigf_utils_test.cpp inv_trigf_utils_test.cpp
DEPENDS DEPENDS
libc.src.math.generic.inv_trigf_utils libc.src.math.generic.inv_trigf_utils
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
) )
add_fp_unittest( add_fp_unittest(
pow_test
NEED_MPFR
SUITE
libc_math_unittests
SRCS
pow_test.cpp
DEPENDS
libc.src.errno.errno
libc.src.math.pow
)
add_fp_unittest(
scalbn_test scalbn_test
NEED_MPFR NEED_MPFR
SUITE SUITE
libc_math_unittests libc_math_unittests
SRCS SRCS
scalbn_test.cpp scalbn_test.cpp
HDRS HDRS
ScalbnTest.h ScalbnTest.h
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines

libc/test/src/math/asin_test.cpp

  • This file was deleted.
//===-- Unittests for asin ------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/errno/libc_errno.h"
#include "src/math/asin.h"
#include "test/UnitTest/FPMatcher.h"
#include "test/UnitTest/Test.h"
#include "utils/MPFRWrapper/MPFRUtils.h"
#include <math.h>
#include <errno.h>
#include <stdint.h>
using FPBits = __llvm_libc::fputil::FPBits<double>;
namespace mpfr = __llvm_libc::testing::mpfr;
DECLARE_SPECIAL_CONSTANTS(double)
TEST(LlvmLibcAsinTest, SpecialNumbers) {
libc_errno = 0;
EXPECT_FP_EQ(aNaN, __llvm_libc::asin(aNaN));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(0.0, __llvm_libc::asin(0.0));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(-0.0, __llvm_libc::asin(-0.0));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(aNaN, __llvm_libc::asin(inf));
EXPECT_MATH_ERRNO(EDOM);
EXPECT_FP_EQ(aNaN, __llvm_libc::asin(neg_inf));
EXPECT_MATH_ERRNO(EDOM);
}

libc/test/src/math/pow_test.cpp

  • This file was deleted.
//===-- Unittests for pow -------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/errno/libc_errno.h"
#include "src/math/pow.h"
#include "test/UnitTest/FPMatcher.h"
#include "test/UnitTest/Test.h"
#include "utils/MPFRWrapper/MPFRUtils.h"
#include <math.h>
#include <errno.h>
#include <stdint.h>
using FPBits = __llvm_libc::fputil::FPBits<double>;
namespace mpfr = __llvm_libc::testing::mpfr;
DECLARE_SPECIAL_CONSTANTS(double)
TEST(LlvmLibcAsinTest, SpecialNumbers) {
libc_errno = 0;
EXPECT_FP_EQ(aNaN, __llvm_libc::pow(aNaN, aNaN));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(1.0, __llvm_libc::pow(1.0, 1.0));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(1.0, __llvm_libc::pow(1.0, 2.0));
EXPECT_MATH_ERRNO(0);
EXPECT_FP_EQ(inf, __llvm_libc::pow(2.0, inf));
}
libc/test/src/math/CMakeLists.txt