This is an archive of the discontinued LLVM Phabricator instance.

Differential D148678

bazel patch for OpenACC changes
ClosedPublic

Authored by aartbik on Apr 18 2023, 6:19 PM.

Details

Reviewers
razvanlupusoru
nicolasvasilache
anlunx
Commits
rGec42398e8aee: bazel patch for OpenACC changes

Diff Detail

Event Timeline

aartbik created this revision.Apr 18 2023, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 6:19 PM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 22 others. · View Herald Transcript
aartbik requested review of this revision.Apr 18 2023, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 6:19 PM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik retitled this revision from build fix to bazel patch for OpenACC changes.Apr 18 2023, 6:20 PM
Herald added a subscriber: sunshaoce. · View Herald TranscriptApr 18 2023, 6:20 PM
aartbik added reviewers: razvanlupusoru, nicolasvasilache.Apr 18 2023, 6:20 PM
anlunx accepted this revision.Apr 18 2023, 6:23 PM
This revision is now accepted and ready to land.Apr 18 2023, 6:23 PM
aartbik mentioned this in D148673: [mlir][openacc] Fix build after D148389.Apr 18 2023, 6:24 PM
razvanlupusoru added inline comments.Apr 18 2023, 6:26 PM
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
10189–10191

Seems unrelated.

razvanlupusoru accepted this revision.EditedApr 18 2023, 6:27 PM

Seems OK to me. Thank you!

aartbik updated this revision to Diff 514801.Apr 18 2023, 6:27 PM

rebased with main

aartbik marked an inline comment as done.Apr 18 2023, 6:28 PM
aartbik added inline comments.
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
10189–10191

Yeah, this was not rebased right. Gone now.

razvanlupusoru accepted this revision.Apr 18 2023, 6:29 PM
Harbormaster completed remote builds in B226498: Diff 514801.Apr 18 2023, 6:37 PM
This revision was landed with ongoing or failed builds.Apr 18 2023, 6:43 PM
Closed by commit rGec42398e8aee: bazel patch for OpenACC changes (authored by aartbik). · Explain Why
This revision was automatically updated to reflect the committed changes.
aartbik marked an inline comment as done.
aartbik added a commit: rGec42398e8aee: bazel patch for OpenACC changes.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
55 lines

Diff 514803

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,807 Lines • ▼ Show 20 Linesgentbl_cc_library(
td_file = "//llvm:include/llvm/Frontend/OpenACC/ACC.td", td_file = "//llvm:include/llvm/Frontend/OpenACC/ACC.td",
deps = ["//llvm:acc_td_files"], deps = ["//llvm:acc_td_files"],
) )
td_library( td_library(
name = "OpenAccOpsTdFiles", name = "OpenAccOpsTdFiles",
srcs = [ srcs = [
"include/mlir/Dialect/OpenACC/AccCommon.td", "include/mlir/Dialect/OpenACC/AccCommon.td",
"include/mlir/Dialect/OpenACC/OpenACCBase.td",
"include/mlir/Dialect/OpenACC/OpenACCOps.td", "include/mlir/Dialect/OpenACC/OpenACCOps.td",
"include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td",
"include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td",
], ],
includes = ["include"], includes = ["include"],
deps = [":OpBaseTdFiles"], deps = [":OpBaseTdFiles"],
) )
gentbl_cc_library( gentbl_cc_library(
name = "OpenACCOpsIncGen", name = "OpenACCOpsIncGen",
strip_include_prefix = "include", strip_include_prefix = "include",
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines tbl_outs = [
), ),
( (
["-gen-op-doc"], ["-gen-op-doc"],
"g3doc/Dialects/OpenACC/OpenACCOps.md", "g3doc/Dialects/OpenACC/OpenACCOps.md",
), ),
], ],
tblgen = ":mlir-tblgen", tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/OpenACC/OpenACCOps.td", td_file = "include/mlir/Dialect/OpenACC/OpenACCOps.td",
deps = [
":BuiltinDialectTdFiles",
":OpenAccOpsTdFiles",
":SideEffectInterfacesTdFiles",
],
)
gentbl_cc_library(
name = "OpenACCTypesIncGen",
strip_include_prefix = "include",
tbl_outs = [
(
[
"--gen-typedef-decls",
"-typedefs-dialect=acc",
],
"include/mlir/Dialect/OpenACC/OpenACCOpsTypes.h.inc",
),
(
[
"--gen-typedef-defs",
"-typedefs-dialect=acc",
],
"include/mlir/Dialect/OpenACC/OpenACCOpsTypes.cpp.inc",
),
],
tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/OpenACC/OpenACCOpsTypes.td",
deps = [":OpenAccOpsTdFiles"],
)
gentbl_cc_library(
name = "OpenACCTypeInterfacesIncGen",
strip_include_prefix = "include",
tbl_outs = [
(
["-gen-type-interface-decls"],
"include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.h.inc",
),
(
["-gen-type-interface-defs"],
"include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.cpp.inc",
),
],
tblgen = ":mlir-tblgen",
td_file = "include/mlir/Dialect/OpenACC/OpenACCTypeInterfaces.td",
deps = [":OpenAccOpsTdFiles"], deps = [":OpenAccOpsTdFiles"],
) )
cc_library( cc_library(
name = "OpenACCDialect", name = "OpenACCDialect",
srcs = glob( srcs = glob(
[ [
"lib/Dialect/OpenACC/IR/*.cpp", "lib/Dialect/OpenACC/IR/*.cpp",
"lib/Dialect/OpenACC/IR/*.h", "lib/Dialect/OpenACC/IR/*.h",
], ],
), ),
hdrs = glob([ hdrs = glob([
"include/mlir/Dialect/OpenACC/*.h", "include/mlir/Dialect/OpenACC/*.h",
]), ]),
includes = ["include"], includes = ["include"],
deps = [ deps = [
":IR", ":IR",
":LLVMDialect",
":MemRefDialect",
":OpenACCOpsIncGen", ":OpenACCOpsIncGen",
":OpenACCTypeInterfacesIncGen",
":OpenACCTypesIncGen",
":Transforms", ":Transforms",
"//llvm:Support", "//llvm:Support",
], ],
) )
## OpenMP dialect ## OpenMP dialect
# TODO(gcmn): This is sticking td files in a cc_library # TODO(gcmn): This is sticking td files in a cc_library
▲ Show 20 Lines • Show All 167 Lines • ▼ Show 20 Linescc_library(
]), ]),
includes = ["include"], includes = ["include"],
deps = [ deps = [
":ArithDialect", ":ArithDialect",
":ConversionPassIncGen", ":ConversionPassIncGen",
":FuncDialect", ":FuncDialect",
":IR", ":IR",
":OpenACCDialect", ":OpenACCDialect",
":OpenACCOpsIncGen",
":OpenACCTypesIncGen",
":Pass", ":Pass",
":SCFDialect", ":SCFDialect",
":Transforms", ":Transforms",
], ],
) )
cc_library( cc_library(
name = "OpenACCToLLVM", name = "OpenACCToLLVM",
▲ Show 20 Lines • Show All 2,040 Lines • ▼ Show 20 Lines deps = [
":BufferizationDialect", ":BufferizationDialect",
":BufferizationTransforms", ":BufferizationTransforms",
":FuncDialect", ":FuncDialect",
":FuncTransforms", ":FuncTransforms",
":IR", ":IR",
":InferIntRangeInterface", ":InferIntRangeInterface",
":MemRefDialect", ":MemRefDialect",
":Pass", ":Pass",
":Support", ":Support",
":TensorDialect", ":TensorDialect",
":TransformUtils", ":TransformUtils",
razvanlupusoruUnsubmitted
Done
ReplyInline Actions

Seems unrelated.

razvanlupusoru: Seems unrelated.
aartbikAuthorUnsubmitted
Done
ReplyInline Actions

Yeah, this was not rebased right. Gone now.

aartbik: Yeah, this was not rebased right. Gone now.
":Transforms", ":Transforms",
":ValueBoundsOpInterface", ":ValueBoundsOpInterface",
":VectorDialect", ":VectorDialect",
"//llvm:Support", "//llvm:Support",
], ],
) )
cc_library( cc_library(
▲ Show 20 Lines • Show All 978 Lines • Show Last 20 Lines