[mlir][linalg] ValueBoundsOpInterface: Add support for linalg.index

[kuhar]

mlir/lib/Dialect/Linalg/IR/ValueBoundsOpInterfaceImpl.cpp

34

nit: prefer free cast functions: https://mlir.llvm.org/deprecation/

also below

36

nit: is there a more descriptive name we could use?

mlir/test/Dialect/Linalg/value-bounds-op-interface-impl.mlir

53

nice! Would it be worth also checking that the LB is 0?

[springerm]

mlir/lib/Dialect/Linalg/IR/ValueBoundsOpInterfaceImpl.cpp

34

This does not work for AffineExpr yet.

[springerm]

address comments

mlir/lib/Dialect/Linalg/IR/ValueBoundsOpInterfaceImpl.cpp

 #include "mlir/Interfaces/ValueBoundsOpInterface.h"
 
 using namespace mlir;
 
 namespace mlir {
 namespace linalg {
 namespace {
 
+struct IndexOpInterface
+    : public ValueBoundsOpInterface::ExternalModel<IndexOpInterface, IndexOp> {
+  void populateBoundsForIndexValue(Operation *op, Value value,
+                                   ValueBoundsConstraintSet &cstr) const {
+    auto indexOp = cast<IndexOp>(op);
+    auto linalgOp = indexOp->getParentOfType<LinalgOp>();
+    assert(value == indexOp.getResult() && "invalid value");
+
+    // index >= 0
+    cstr.bound(value) >= 0;
+
+    // index < dim size
+    int64_t flatDimPos = linalgOp.getShapesToLoopsMap()
+                             .getResult(indexOp.getDim())
+                             .cast<AffineDimExpr>()
+                             .getPosition();
+    // Find the `flatDimPos`-th operand dimension.
+    int64_t flatDimCtr = 0;
+    for (Value operand : linalgOp->getOperands()) {
+      assert(flatDimPos >= flatDimCtr && "invalid pos");
+      auto shapedType = operand.getType().cast<ShapedType>();
+      if (flatDimPos < flatDimCtr + shapedType.getRank()) {
+        cstr.bound(value) < cstr.getExpr(operand, flatDimPos - flatDimCtr);
+        break;
+      }
+      flatDimCtr += shapedType.getRank();
+    }
+  }
+};
+
 /// Helper structure that iterates over all LinalgOps in `OpTys` and registers
 /// the `ValueBoundsOpInterface` with each of them.
 template <typename... Ops> struct LinalgValueBoundsOpInterfaceHelper {
   static void registerOpInterface(MLIRContext *ctx) {
     (Ops::template attachInterface<DstValueBoundsOpInterfaceExternalModel<Ops>>(
          *ctx),
      ...);
   }
 };
 
 } // namespace
 } // namespace linalg
 } // namespace mlir
 
 void mlir::linalg::registerValueBoundsOpInterfaceExternalModels(
     DialectRegistry &registry) {
   registry.addExtension(+[](MLIRContext *ctx, linalg::LinalgDialect *dialect) {
+    IndexOp::attachInterface<IndexOpInterface>(*ctx);
+
     // Register all Linalg structured ops.
     LinalgValueBoundsOpInterfaceHelper<
 #define GET_OP_LIST
 #include "mlir/Dialect/Linalg/IR/LinalgStructuredOps.cpp.inc"
         >::registerOpInterface(ctx);
   });
 }

mlir/test/Dialect/Linalg/value-bounds-op-interface-impl.mlir

 // RUN: mlir-opt %s -test-affine-reify-value-bounds -verify-diagnostics \
 // RUN:     -split-input-file | FileCheck %s
 
 // CHECK-LABEL: func @linalg_fill(
 //  CHECK-SAME:     %[[t:.*]]: tensor<?xf32>
 //       CHECK:   %[[c0:.*]] = arith.constant 0 : index
 //       CHECK:   %[[dim:.*]] = tensor.dim %[[t]], %[[c0]]
 //       CHECK:   return %[[dim]]
 func.func @linalg_fill(%t: tensor<?xf32>, %f: f32) -> index {
   %0 = linalg.fill ins(%f : f32) outs(%t : tensor<?xf32>) -> tensor<?xf32>
   %1 = "test.reify_bound"(%0) {dim = 0} : (tensor<?xf32>) -> (index)
   return %1 : index
 }
+
+// -----
+
+#accesses = [
+  affine_map<(i, j, k) -> (j, i)>,
+  affine_map<(i, j, k) -> (i, k, i + j)>
+]
+
+#trait = {
+  indexing_maps = #accesses,
+  iterator_types = ["parallel", "parallel", "parallel"]
+}
+
+// CHECK-LABEL: func @linalg_index(
+//  CHECK-SAME:     %[[arg0:.*]]: memref<?x?xf32>
+func.func @linalg_index(%arg0: memref<?x?xf32>,
+                        %arg1: memref<?x5x?xf32>) {
+  linalg.generic #trait
+                 ins(%arg0 : memref<?x?xf32>)
+                 outs(%arg1 : memref<?x5x?xf32>)
+  {
+    ^bb(%a: f32, %b: f32):
+      // CHECK: %[[c1:.*]] = arith.constant 1 : index
+      // CHECK: %[[ub_0:.*]] = memref.dim %[[arg0]], %[[c1]]
+      // CHECK: "test.some_use"(%[[ub_0]])
+      %0 = linalg.index 0 : index
+      %ub_0 = "test.reify_bound"(%0) {type = "UB"} : (index) -> (index)
+      "test.some_use"(%ub_0) : (index) -> ()
+
+      // CHECK: %[[c0:.*]] = arith.constant 0 : index
+      // CHECK: "test.some_use"(%[[c0]])
+      %lb_0 = "test.reify_bound"(%0) {type = "LB"} : (index) -> (index)
+      "test.some_use"(%lb_0) : (index) -> ()
+
+      // CHECK: %[[c0:.*]] = arith.constant 0 : index
+      // CHECK: %[[ub_1:.*]] = memref.dim %[[arg0]], %[[c0]]
+      // CHECK: "test.some_use"(%[[ub_1]])
+      %1 = linalg.index 1 : index
+      %ub_1 = "test.reify_bound"(%1) {type = "UB"} : (index) -> (index)
+      "test.some_use"(%ub_1) : (index) -> ()
+
+      // CHECK: %[[ub_2:.*]] = arith.constant 5 : index
+      // CHECK: "test.some_use"(%[[ub_2]])
+      %2 = linalg.index 2 : index
+      %ub_2 = "test.reify_bound"(%2) {type = "UB"} : (index) -> (index)
+      "test.some_use"(%ub_2) : (index) -> ()
+
+      linalg.yield %b : f32
+  }
+  return
+}