This is an archive of the discontinued LLVM Phabricator instance.

Differential D148572

[libc][Bazel][NFC] add missing string deps
ClosedPublic

Authored by michaelrj on Apr 17 2023, 2:27 PM.

Details

Reviewers
sivachandra
Commits
rGe3d764597f5e: [libc][Bazel][NFC] add missing string deps
Summary

With the recent move away from StringStream some tests were given a
dependency on cpp::string. Some of these were missed for the bazel
build, causing build failures.

Diff Detail

Event Timeline

michaelrj created this revision.Apr 17 2023, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 2:27 PM
Herald added subscribers: ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Apr 17 2023, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 2:27 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
michaelrj updated this revision to Diff 514412.Apr 17 2023, 2:34 PM

add MPFRutils fix

michaelrj retitled this revision from [libc][Bazel][NFC] add missing string dep to [libc][Bazel][NFC] add missing string deps.Apr 17 2023, 2:34 PM
michaelrj edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2023, 2:37 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGe3d764597f5e: [libc][Bazel][NFC] add missing string deps (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGe3d764597f5e: [libc][Bazel][NFC] add missing string deps.
lntue added a reviewer: lntue.Apr 17 2023, 2:47 PM
lntue removed a reviewer: lntue.
lntue added a subscriber: lntue.
Harbormaster completed remote builds in B226226: Diff 514412.Apr 17 2023, 3:04 PM

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
libc/
test/
UnitTest/
1 line
utils/
MPFRWrapper/
1 line

Diff 514415

utils/bazel/llvm-project-overlay/libc/test/UnitTest/BUILD.bazel

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
) )
cc_library( cc_library(
name = "string_utils", name = "string_utils",
hdrs = [ hdrs = [
"StringUtils.h", "StringUtils.h",
], ],
deps = [ deps = [
"//libc:__support_cpp_string",
"//libc:__support_cpp_type_traits", "//libc:__support_cpp_type_traits",
], ],
) )

utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel

Show All 32 Lines features = select(
"//conditions:default": [], "//conditions:default": [],
"//libc:mpfr_system": ["-layering_check"], "//libc:mpfr_system": ["-layering_check"],
}, },
), ),
deps = [ deps = [
"//libc:__support_common", "//libc:__support_common",
"//libc:__support_cpp_bit", "//libc:__support_cpp_bit",
"//libc:__support_cpp_bitset", "//libc:__support_cpp_bitset",
"//libc:__support_cpp_string",
"//libc:__support_cpp_string_view", "//libc:__support_cpp_string_view",
"//libc:__support_cpp_type_traits", "//libc:__support_cpp_type_traits",
"//libc:__support_fputil_fp_bits", "//libc:__support_fputil_fp_bits",
"//libc:__support_fputil_platform_defs", "//libc:__support_fputil_platform_defs",
"//libc:libc_root", "//libc:libc_root",
"//libc/test/UnitTest:LibcUnitTest", "//libc/test/UnitTest:LibcUnitTest",
"//libc/test/UnitTest:fp_test_helpers", "//libc/test/UnitTest:fp_test_helpers",
"//libc/utils/MPFRWrapper:mpfr_impl", "//libc/utils/MPFRWrapper:mpfr_impl",
"//libc/utils/testutils:libc_test_utils", "//libc/utils/testutils:libc_test_utils",
], ],
) )