This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy][NFC] Improved hungarian notation regression test at post-commit review
ClosedPublic

Authored by dougpuob on Apr 14 2023, 2:01 AM.

Details

Summary

Improve the (D144510)[https://reviews.llvm.org/D144510] patch with prefix string. Using "my" instead of "cust" would increase
readability.

Take some examples:

  • const char* custszNamePtr = "Name"; --> myszNamePtr
  • uint8_t custu8ValueU8 = 0; --> myu8ValueU8
  • DWORD custdwMsDword = 0; --> mydwMsDword

Diff Detail

Event Timeline

dougpuob created this revision.Apr 14 2023, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2023, 2:01 AM
dougpuob requested review of this revision.Apr 14 2023, 2:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2023, 2:01 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
PiotrZSL requested changes to this revision.Apr 14 2023, 2:22 AM
PiotrZSL added a subscriber: PiotrZSL.
PiotrZSL added inline comments.
clang-tools-extra/docs/ReleaseNotes.rst
264–267 ↗(On Diff #513492)

Don't put this into release notes, in release notes we put only information that impact users.

This revision now requires changes to proceed.Apr 14 2023, 2:22 AM

And you forget to attach changes in unit tests.

dougpuob updated this revision to Diff 513586.Apr 14 2023, 7:25 AM

Against trunk.

And you forget to attach changes in unit tests.

My bad, I against to a wrong one.

clang-tools-extra/docs/ReleaseNotes.rst
264–267 ↗(On Diff #513492)

Make sense, I will remove it in next commit.

PiotrZSL accepted this revision.Apr 14 2023, 7:55 AM

Change in tests is ok, change in release notes not needed (please remove).
Change title into [clang-tidy][NFC] Improved ...

NFC - Non Functional Change

This revision is now accepted and ready to land.Apr 14 2023, 7:55 AM
dougpuob updated this revision to Diff 513648.Apr 14 2023, 9:53 AM
  • Removed unnecessary information from ReleaseNotes.rst
dougpuob retitled this revision from [clang-tidy] Improved hungarian notation regression test at post-commit review to [clang-tidy][NFC] Improved hungarian notation regression test at post-commit review.Apr 14 2023, 9:55 AM
dougpuob added a reviewer: amurzeau.
dougpuob marked an inline comment as done.Apr 14 2023, 9:59 AM

Change in tests is ok, change in release notes not needed (please remove).
Change title into [clang-tidy][NFC] Improved ...

NFC - Non Functional Change

Thank you for the review :)
I removed the release notes and changed the title.

PiotrZSL accepted this revision.Apr 14 2023, 10:18 AM

I will push into repository this in a moment....

I will push into repository this in a moment....

@PiotrZSL, Thank you.