This is an archive of the discontinued LLVM Phabricator instance.

Differential D148253

[flang][openacc] Add proper TODO for the block construct
ClosedPublic

Authored by clementval on Apr 13 2023, 10:13 AM.

Details

Reviewers
PeteSteinfeld
razvanlupusoru
Commits
rGbc7c9be7b1e9: [flang][openacc] Add proper TODO for the block construct
Summary

Trigger the not yet implemented message for
block constructs that are not lowered.

Diff Detail

Event Timeline

clementval created this revision.Apr 13 2023, 10:13 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 13 2023, 10:13 AM
Herald added subscribers: sunshaoce, mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Apr 13 2023, 10:13 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 13 2023, 10:13 AM
razvanlupusoru accepted this revision.Apr 13 2023, 10:14 AM
This revision is now accepted and ready to land.Apr 13 2023, 10:14 AM
PeteSteinfeld accepted this revision.Apr 13 2023, 10:44 AM

All builds and tests correctly and looks good.

Harbormaster completed remote builds in B225394: Diff 513292.Apr 13 2023, 11:26 AM
Closed by commit rGbc7c9be7b1e9: [flang][openacc] Add proper TODO for the block construct (authored by clementval). · Explain WhyApr 13 2023, 11:33 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rGbc7c9be7b1e9: [flang][openacc] Add proper TODO for the block construct.

Revision Contents

PathSize
flang/
lib/
Lower/
6 lines

Diff 513292

flang/lib/Lower/OpenACC.cpp

Show First 20 Lines • Show All 698 Lines • ▼ Show 20 LinesgenACC(Fortran::lower::AbstractConverter &converter,
Fortran::lower::StatementContext stmtCtx; Fortran::lower::StatementContext stmtCtx;
if (blockDirective.v == llvm::acc::ACCD_parallel) { if (blockDirective.v == llvm::acc::ACCD_parallel) {
genACCParallelOp(converter, currentLocation, semanticsContext, stmtCtx, genACCParallelOp(converter, currentLocation, semanticsContext, stmtCtx,
accClauseList); accClauseList);
} else if (blockDirective.v == llvm::acc::ACCD_data) { } else if (blockDirective.v == llvm::acc::ACCD_data) {
genACCDataOp(converter, currentLocation, semanticsContext, stmtCtx, genACCDataOp(converter, currentLocation, semanticsContext, stmtCtx,
accClauseList); accClauseList);
} else if (blockDirective.v == llvm::acc::ACCD_serial) {
TODO(currentLocation, "serial construct lowering");
} else if (blockDirective.v == llvm::acc::ACCD_kernels) {
TODO(currentLocation, "kernels construct lowering");
} else if (blockDirective.v == llvm::acc::ACCD_host_data) {
TODO(currentLocation, "host_data construct lowering");
} }
} }
static void static void
genACCParallelLoopOps(Fortran::lower::AbstractConverter &converter, genACCParallelLoopOps(Fortran::lower::AbstractConverter &converter,
mlir::Location currentLocation, mlir::Location currentLocation,
Fortran::semantics::SemanticsContext &semanticsContext, Fortran::semantics::SemanticsContext &semanticsContext,
Fortran::lower::StatementContext &stmtCtx, Fortran::lower::StatementContext &stmtCtx,
▲ Show 20 Lines • Show All 464 Lines • Show Last 20 Lines