This is an archive of the discontinued LLVM Phabricator instance.

[GISel] Legalize G_FSUB to G_FADD + G_FNEG even if G_FNEG is illegal
ClosedPublic

Authored by barannikov88 on Apr 12 2023, 6:42 PM.

Details

Summary

G_FNEG used to be legalized to G_FSUB -0, x causing infinite loop.
This is no longer the case after D84287.

Diff Detail

Event Timeline

barannikov88 created this revision.Apr 12 2023, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 6:42 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
barannikov88 requested review of this revision.Apr 12 2023, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 6:42 PM

Any idea how to test it?

arsenm accepted this revision.Apr 14 2023, 1:36 PM

LGTM. I don't think there's anything to test

This revision is now accepted and ready to land.Apr 14 2023, 1:36 PM
This revision was landed with ongoing or failed builds.Apr 14 2023, 10:12 PM
This revision was automatically updated to reflect the committed changes.