[mlir][func] Guard for unranked memref with the bare ptr memref call

[Lewuathe]

Summary

Lowering the call op with use-bare-ptr-memref-call crashes due to the unsupported unranked memref type. We can prevent the crash by checking the type of operand in the pass instead of the assertion in the type converter.

Issue: https://github.com/llvm/llvm-project/issues/61872

mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp

LogicalResult matchAndRewriteImpl(CallOpType callOp,
     auto resultTypes = llvm::to_vector<4>(callOp.getResultTypes());
 
     if (numResults != 0) {
       if (!(packedResult = this->getTypeConverter()->packFunctionResults(
                 resultTypes, useBarePtrCallConv)))
         return failure();
     }
 
+    if (useBarePtrCallConv) {
+      for (auto it : callOp->getOperands()) {
+        Type operandType = it.getType();
+        if (operandType.isa<UnrankedMemRefType>()) {
+          // Unranked memref is not supported in the bare pointer calling
+          // convention.
+          return failure();
+        }
+      }
+    }
     auto promoted = this->getTypeConverter()->promoteOperands(
         callOp.getLoc(), /*opOperands=*/callOp->getOperands(),
         adaptor.getOperands(), rewriter, useBarePtrCallConv);
     auto newOp = rewriter.create<LLVM::CallOp>(
         callOp.getLoc(), packedResult ? TypeRange(packedResult) : TypeRange(),
         promoted, callOp->getAttrs());
 
     SmallVector<Value, 4> results;

mlir/test/Conversion/FuncToLLVM/func-memref-return.mlir

 
 // -----
 
 // BAREPTR-LABEL: func @unconvertible_multiresult
 // BAREPTR-SAME: %{{.*}}: memref<?xf32>, %{{.*}}: memref<?xf32>) -> (memref<?xf32>, memref<?xf32>)
 func.func @unconvertible_multiresult(%arg0: memref<?xf32> , %arg1: memref<?xf32>) -> (memref<?xf32>, memref<?xf32>) {
   return %arg0, %arg1 : memref<?xf32>, memref<?xf32>
 }
+
+// -----
+// BAREPTR-LABEL: func @unranked_memref(
+// BAREPTR-SAME: %{{.*}}: memref<*xi32>)
+func.func @unranked_memref(%arg0:memref<*xi32>) {
+  // BAREPTR:      call @printMemrefI32(%arg{{.*}}) : (memref<*xi32>) -> ()
+  // BAREPTR-NEXT: llvm.return
+  call @printMemrefI32(%arg0) : (memref<*xi32>) -> ()
+  return
+}
+func.func private @printMemrefI32(memref<*xi32>)