This PR introduces the BrStack member to store the info about
loop, block, if and try. It can check whether br immediate number
out of range.
Details
Details
- Reviewers
aheejin - Commits
- rGdb1dac1e20bd: [WebAssembly] `AsmTypeCheck` support to br instr
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for the simplified version!
llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp | ||
---|---|---|
144–146 | I think it'd be better to start BrStack as the function return signature in the beginning than treating this as a special case. Currently we cannot check if the stack-remaining value types at the time of br matches the function return signature. | |
147 | ||
llvm/test/MC/WebAssembly/type-checker-errors.s | ||
744 | try~end_try without a catch/catch_all is malformed. | |
749–750 | ||
772 | Can we add a few more tests on the depth?
|
I think it'd be better to start BrStack as the function return signature in the beginning than treating this as a special case. Currently we cannot check if the stack-remaining value types at the time of br matches the function return signature.