This is an archive of the discontinued LLVM Phabricator instance.

[RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)
AbandonedPublic

Authored by barannikov88 on Apr 10 2023, 12:23 PM.

Diff Detail

Event Timeline

barannikov88 created this revision.Apr 10 2023, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 12:23 PM
barannikov88 requested review of this revision.Apr 10 2023, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 12:23 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
barannikov88 edited the summary of this revision. (Show Details)Apr 10 2023, 1:31 PM
barannikov88 edited the summary of this revision. (Show Details)

clang-format and comment fix

arsenm accepted this revision.Apr 10 2023, 1:57 PM
arsenm added a subscriber: arsenm.

Seems like an obvious organizational improvement

This revision is now accepted and ready to land.Apr 10 2023, 1:57 PM

Adding the codegen code owners for their approval, but in general I think this is a good idea.

clang/lib/CodeGen/ABIInfoImpl.h
33–52

Because we're sort of elevating these from implementation details hidden in the .cpp to interfaces exposed via a header file, we should probably document these functions better (not needed as part of this change though).

barannikov88 abandoned this revision.Jun 16 2023, 9:25 PM

Abandoning as D148094 landed.