This is an archive of the discontinued LLVM Phabricator instance.

[libc] Update supported riscv libs
ClosedPublic

Authored by mikhail.ramalho on Apr 10 2023, 12:18 PM.

Details

Summary

This patch updates the list of supported libs according to the latest changes to x86_64

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 10 2023, 12:18 PM
mikhail.ramalho requested review of this revision.Apr 10 2023, 12:18 PM

The last time I checked, log10 had failures. Was it fixed with the FMA change?

The last time I checked, log10 had failures. Was it fixed with the FMA change?

Do you mean these messages?

[1735/2157] Running unit test libc.test.src.math.log10_test
[ RUN      ] LlvmLibcLog10Test.SpecialNumbers
[       OK ] LlvmLibcLog10Test.SpecialNumbers
[ RUN      ] LlvmLibcLog10Test.TrickyInputs
[       OK ] LlvmLibcLog10Test.TrickyInputs
[ RUN      ] LlvmLibcLog10Test.InDoubleRange
 Test Rounding To Nearest...
 Log10 failed: 0/1234562/1234562 tests.
   Max ULPs is at most: 0.5.
 Test Rounding Downward...
 Log10 failed: 0/1234562/1234562 tests.
   Max ULPs is at most: 0.5.
 Test Rounding Upward...
 Log10 failed: 0/1234562/1234562 tests.
   Max ULPs is at most: 0.5.
 Test Rounding Toward Zero...
 Log10 failed: 0/1234562/1234562 tests.
   Max ULPs is at most: 0.5.
[       OK ] LlvmLibcLog10Test.InDoubleRange
Ran 3 tests.  PASS: 3  FAIL: 0

Both x86_64 and riscv64 print them, and the test doesn't fail.

sivachandra accepted this revision.Apr 17 2023, 12:05 PM

Those print messages are now deleted - if you sync and rebuild/rerun, they should go away. I remember seeing real failures which turned the bot red when it was still connected staging. But, if there are no failures now, go ahead and land.

This revision is now accepted and ready to land.Apr 17 2023, 12:05 PM

This is the failure the bot is still seeing: https://lab.llvm.org/buildbot/#/builders/256/builds/1030

Yeah, I just got the email... I'll remove the log10 while I try to figure out what's the issue and why I can't reproduce it.