Mark functions and types with the appropriate visibility. This is particularly
useful for environments which explicitly indicate origin of functions (Windows).
This aids in ensuring libc++abi as a DSO which exposes only the public
interfaces.
Details
- Reviewers
mclow.lists compnerd EricWF
Diff Detail
Event Timeline
include/__cxxabi_config.h | ||
---|---|---|
24 | s/LIBCXXABI_DLL/_LIBCXXABI_DLL/ |
include/__cxxabi_config.h | ||
---|---|---|
24 | Sure, though the thing is that this would be different from libc++, which uses LIBCPP_DLL. |
include/__cxxabi_config.h | ||
---|---|---|
24 | Two wrongs don't make a right... |
This looks fine to me.
A note - the pervasive whitespace changes obscure the substantive changes.
In an ideal world, they would be two different changes.
include/__cxxabi_config.h | ||
---|---|---|
24 | I'm wondering where you see use of LIBCPP_DLL in libc++. The only place I see is in __config:182, which uses _LIBCPP_DLL, and has since (at least) 2011. (Because @jroelofs is correct) |
Sure, I can split it up into two changes, one for the formatting, and one for the material changes before committing.
Applied the bulk of the whitespace changes in a separate commit (SVN r254690) and the annotation work in SVN r254691.
s/LIBCXXABI_DLL/_LIBCXXABI_DLL/