Mark functions and types with the appropriate visibility. This is particularly
useful for environments which explicitly indicate origin of functions (Windows).
This aids in ensuring libc++abi as a DSO which exposes only the public
This looks fine to me.
A note - the pervasive whitespace changes obscure the substantive changes.
In an ideal world, they would be two different changes.
I'm wondering where you see use of LIBCPP_DLL in libc++.
The only place I see is in __config:182, which uses _LIBCPP_DLL, and has since (at least) 2011.
(Because @jroelofs is correct)