This is an archive of the discontinued LLVM Phabricator instance.

Differential D147862

[compiler-rt] [test] Generalize the triple regex for windows XFAILs
ClosedPublic

Authored by mstorsjo on Apr 8 2023, 1:17 PM.

Details

Reviewers
phosek
alvinhochun
vitalybuka
omjavaid
Commits
rG25350a736250: [compiler-rt] [test] Generalize the triple regex for windows XFAILs
Summary

Don't hardcode the vendor field in the triples to "pc"; for mingw
environments it's often "<arch>-w64-windows-gnu".

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 8 2023, 1:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2023, 1:17 PM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
mstorsjo requested review of this revision.Apr 8 2023, 1:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2023, 1:17 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B224394: Diff 511927.Apr 8 2023, 1:36 PM
phosek accepted this revision.Apr 8 2023, 2:06 PM

LGTM

This revision is now accepted and ready to land.Apr 8 2023, 2:06 PM
Closed by commit rG25350a736250: [compiler-rt] [test] Generalize the triple regex for windows XFAILs (authored by mstorsjo). · Explain WhyApr 10 2023, 2:04 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG25350a736250: [compiler-rt] [test] Generalize the triple regex for windows XFAILs.

Revision Contents

PathSize
compiler-rt/
test/
builtins/
Unit/
2 lines
2 lines
2 lines

Diff 512257

compiler-rt/test/builtins/Unit/divmodti4_test.c

// XFAIL: target=aarch64-pc-windows-{{.*}} // XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
// RUN: %clang_builtins %s %librt -o %t && %run %t // RUN: %clang_builtins %s %librt -o %t && %run %t
// REQUIRES: librt_has_divmodti4 // REQUIRES: librt_has_divmodti4
// REQUIRES: int128 // REQUIRES: int128
//===-- divmodti4_test.c - Test __divmodti4 -------------------------------===// //===-- divmodti4_test.c - Test __divmodti4 -------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines

compiler-rt/test/builtins/Unit/fixunstfdi_test.c

// XFAIL: target=aarch64-pc-windows-{{.*}} // XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
// RUN: %clang_builtins %s %librt -o %t && %run %t // RUN: %clang_builtins %s %librt -o %t && %run %t
// REQUIRES: librt_has_fixunstfdi // REQUIRES: librt_has_fixunstfdi
#include <stdio.h> #include <stdio.h>
#if _ARCH_PPC || __aarch64__ #if _ARCH_PPC || __aarch64__
#include "int_lib.h" #include "int_lib.h"
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines

compiler-rt/test/builtins/Unit/multc3_test.c

// XFAIL: target=aarch64-pc-windows-{{.*}} // XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
// RUN: %clang_builtins %s %librt -o %t && %run %t // RUN: %clang_builtins %s %librt -o %t && %run %t
// REQUIRES: librt_has_multc3 // REQUIRES: librt_has_multc3
#include <stdio.h> #include <stdio.h>
#if _ARCH_PPC || __aarch64__ #if _ARCH_PPC || __aarch64__
#include "int_lib.h" #include "int_lib.h"
▲ Show 20 Lines • Show All 357 Lines • Show Last 20 Lines