[lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

[JDevlieghere]

Summary

Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED. We cannot
directly reuse the LLVM one, because it's defined in Compiler.h which is
not something we can include in the SB API.

For the SB API, the macro is undef'd if:

1. We're building the SWIG bindings. We might still want to expose deprecated methods to our scripting users.
2. We're targeting anything older than C++14 as the [[deprecated]] attribute was added for C++14 and the SB API can be used by projects compiling against an older language version.

[JDevlieghere]

FWIW I added the current [[deprecated]] attribute in ea95da180900.

[JDevlieghere]

Add a comment explaining why we're undefing the macro.

[bulbazord]

lldb/include/lldb/API/SBDefines.h

33

nit: Use __cplusplus < 201402L to be more specific.

I got that value from https://en.cppreference.com/w/cpp/preprocessor/replace

[kastiglione]

lldb/include/lldb/API/SBDefines.h

33

@JDevlieghere should this be || instead of or?

lldb/include/lldb/API/SBDefines.h

 #else
 #define LLDB_API __declspec(dllimport)
 #endif
 #else // defined (_WIN32)
 #define LLDB_API
 #endif
 #endif
 
+// Don't add the deprecated attribute when generating the bindings or when
+// building for anything older than C++14 which is the first version that
+// supports the attribute.
+#if defined(SWIG) or _cplusplus < 201402L
+#undef LLDB_DEPRECATED
+#define LLDB_DEPRECATED(MSG, FIX)
+#endif
+
 // Forward Declarations
 namespace lldb {
 
 class LLDB_API SBAddress;
 class LLDB_API SBBlock;
 class LLDB_API SBBreakpoint;
 class LLDB_API SBBreakpointLocation;
 class LLDB_API SBBreakpointName;

lldb/include/lldb/API/SBTarget.h

#ifndef SWIG
   ///
   /// \param[in] sections_offset
   ///     An offset that will be applied to all section file addresses
   ///     (the virtual addresses found in the object file itself).
   ///
   /// \return
   ///     An error to indicate success, fail, and any reason for
   ///     failure.
-  [[deprecated("Use SetModuleLoadAddress(lldb::SBModule, uint64_t)")]]
+  LLDB_DEPRECATED("Use SetModuleLoadAddress(lldb::SBModule, uint64_t)",
+                  "SetModuleLoadAddress(lldb::SBModule, uint64_t)")
   lldb::SBError SetModuleLoadAddress(lldb::SBModule module,
                                      int64_t sections_offset);
 #endif
 
   /// Slide all file addresses for all module sections so that \a module
   /// appears to loaded at these slide addresses.
   ///
   /// When you need all sections within a module to be loaded at a

lldb/include/lldb/lldb-defines.h

 
 // ignore GCC function attributes
 #if defined(_MSC_VER) && !defined(__clang__)
 #define __attribute__(X)
 #endif
 
 #define UNUSED_IF_ASSERT_DISABLED(x) ((void)(x))
 
+#if defined(__clang__)
+#define LLDB_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
+#else
+#define LLDB_DEPRECATED(MSG, FIX) [[deprecated(MSG)]]
+#endif
+
 #endif // LLDB_LLDB_DEFINES_H