This is an archive of the discontinued LLVM Phabricator instance.

Add baseline tests for D147597
ClosedPublic

Authored by junaire on Apr 5 2023, 1:52 AM.

Details

Summary

Signed-off-by: Jun Zhang <jun@junz.org>

Diff Detail

Event Timeline

junaire created this revision.Apr 5 2023, 1:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 1:52 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
junaire requested review of this revision.Apr 5 2023, 1:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 1:52 AM
junaire updated this revision to Diff 511043.Apr 5 2023, 4:24 AM

Update the tests

junaire retitled this revision from Add baseline tests for icmp(Positive1 * X * Y + Positive2) to Add baseline tests for icmp(X * Y + Positive).Apr 5 2023, 4:24 AM
junaire updated this revision to Diff 511055.Apr 5 2023, 5:09 AM

Vector tests

junaire updated this revision to Diff 511308.Apr 6 2023, 1:05 AM
  • remove nsw flag
  • rename the tests
junaire retitled this revision from Add baseline tests for icmp(X * Y + Positive) to Add baseline tests for D147597.Apr 6 2023, 1:07 AM
junaire updated this revision to Diff 511952.Apr 8 2023, 8:07 PM

Add more tests

junaire updated this revision to Diff 512400.Apr 11 2023, 5:04 AM

Add negative tests

junaire updated this revision to Diff 512704.Apr 12 2023, 2:17 AM

rename tests & add multiuse tests

junaire updated this revision to Diff 512720.Apr 12 2023, 2:33 AM

Add vector with poison tests

junaire updated this revision to Diff 512724.Apr 12 2023, 2:38 AM

Update the comments

nikic added inline comments.Apr 12 2023, 1:59 PM
llvm/test/Transforms/InstCombine/icmp.ll
5127

It's usually enough to have just one multi-use test, no need to add multi-use variants of all tests.

junaire updated this revision to Diff 513012.Apr 12 2023, 4:46 PM

Address @nikic's comments, thx! -- only keep one multiuse test

junaire updated this revision to Diff 513015.Apr 12 2023, 4:48 PM

remove unused function

junaire accepted this revision.Apr 13 2023, 2:27 AM
This revision is now accepted and ready to land.Apr 13 2023, 2:27 AM