This is an archive of the discontinued LLVM Phabricator instance.

[flang] Keep the extended value for assumed-type optional
ClosedPublic

Authored by clementval on Apr 4 2023, 2:40 PM.

Details

Summary

Keep the extended value when lowering optional assumed type
dummy argument. The extended value is needed to lower correctly the
rest of the code.

Diff Detail

Event Timeline

clementval created this revision.Apr 4 2023, 2:40 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 4 2023, 2:40 PM
clementval requested review of this revision.Apr 4 2023, 2:40 PM
PeteSteinfeld accepted this revision.Apr 4 2023, 8:10 PM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.Apr 4 2023, 8:10 PM
jeanPerier requested changes to this revision.Apr 5 2023, 1:45 AM
jeanPerier added a subscriber: jeanPerier.

Can you use operands.emplace_back(converter.getSymbolExtendedValue(*assumedTypeSym, symMap)) in convertExpr.cpp instead of moving symBoxToExtendedValue?
Since ConvertExpr.cpp will be superseded, it is inconvenient to have helpers that HLFIR lowering relies upon inside it.

This revision now requires changes to proceed.Apr 5 2023, 1:45 AM
clementval updated this revision to Diff 511117.Apr 5 2023, 8:40 AM

Use converter.getSymbolExtendedValue

jeanPerier accepted this revision.Apr 5 2023, 1:18 PM

Thanks

This revision is now accepted and ready to land.Apr 5 2023, 1:18 PM