[flang] Keep the extended value for assumed-type optional

[clementval]

Summary

Keep the extended value when lowering optional assumed type
dummy argument. The extended value is needed to lower correctly the
rest of the code.

[PeteSteinfeld]

All builds and tests correctly and looks good.

[jeanPerier]

Can you use operands.emplace_back(converter.getSymbolExtendedValue(*assumedTypeSym, symMap)) in convertExpr.cpp instead of moving symBoxToExtendedValue?
Since ConvertExpr.cpp will be superseded, it is inconvenient to have helpers that HLFIR lowering relies upon inside it.

[clementval]

Use converter.getSymbolExtendedValue

[jeanPerier]

Thanks

flang/lib/Lower/ConvertExpr.cpp

for (const auto &arg : llvm::enumerate(procRef.arguments())) {
       auto *expr =
           Fortran::evaluate::UnwrapExpr<Fortran::lower::SomeExpr>(arg.value());
 
       if (!expr && arg.value() && arg.value()->GetAssumedTypeDummy()) {
         // Assumed type optional.
         const Fortran::evaluate::Symbol *assumedTypeSym =
             arg.value()->GetAssumedTypeDummy();
         auto symBox = symMap.lookupSymbol(*assumedTypeSym);
-        operands.emplace_back(symBox.getAddr());
+        operands.emplace_back(
+            converter.getSymbolExtendedValue(*assumedTypeSym, &symMap));
         continue;
       }
       if (!expr) {
         // Absent optional.
         operands.emplace_back(fir::getAbsentIntrinsicArgument());
         continue;
       }
       if (!argLowering) {

flang/test/Lower/assumed-type.f90

subroutine assumed_type_optional_to_intrinsic(a)
     type(*), optional :: a(:)
     if (present(a)) print*, 'present'
   end subroutine
 
 ! CHECK-LABEL: func.func @_QMassumed_type_testPassumed_type_optional_to_intrinsic(
 ! CHECK-SAME: %[[ARG0:.*]]: !fir.box<!fir.array<?xnone>> {fir.bindc_name = "a", fir.optional}) {
 ! CHECK: %{{.*}} = fir.is_present %[[ARG0]] : (!fir.box<!fir.array<?xnone>>) -> i1
 
+  subroutine assumed_type_lbound(a)
+    type(*), optional :: a(:,:)
+    print*,lbound(a,dim=1)
+  end subroutine
+
+! CHECK-LABEL: func.func @_QMassumed_type_testPassumed_type_lbound(
+! CHECK-SAME: %[[ARG0:.*]]: !fir.box<!fir.array<?x?xnone>> {fir.bindc_name = "a", fir.optional}) {
+! CHECK: %[[C1:.*]] = arith.constant 1 : i32
+! CHECK: %{{.*}} = fir.call @_FortranAioOutputInteger32(%{{.*}}, %[[C1]]) {{.*}} : (!fir.ref<i8>, i32) -> i1
+
 end module