This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ][z/OS] Make LIBCXXABI_LIBUNWIND_INCLUDES_INTERNAL available for external unwind library.
ClosedPublic

Authored by zibi on Apr 3 2023, 11:24 AM.

Details

Summary

On z/OS, we need to pass the location of unwind interface header when building cxxabi. The cmake macro LIBCXXABI_LIBUNWIND_INCLUDES_INTERNAL is available for this purpose but it is only used with conjunction with LIBCXXABI_USE_LLVM_UNWINDER. For the external unwind library we need to use LIBCXXABI_LIBUNWIND_INCLUDES_INTERNAL unconditionally whenever it is set.

Diff Detail

Event Timeline

zibi created this revision.Apr 3 2023, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2023, 11:24 AM
zibi requested review of this revision.Apr 3 2023, 11:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2023, 11:24 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
zibi retitled this revision from Make LIBCXXABI_LIBUNWIND_INCLUDES_INTERNAL available for external unwind library. to [SystemZ][z/OS] Make LIBCXXABI_LIBUNWIND_INCLUDES_INTERNAL available for external unwind library..Apr 3 2023, 11:30 AM
zibi added reviewers: muiez, rmaprath, asl, hintonda, phosek, SeanP.
zibi updated this revision to Diff 510649.Apr 3 2023, 5:12 PM
  • fix CI
zibi added a comment.Apr 4 2023, 7:02 AM

The CI failure is unrelated with 1 timeout:

TIMEOUT: llvm-libc++-shared.cfg.in :: std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_notify_one.pass.cpp (5780 of 8044)
muiez accepted this revision.Apr 6 2023, 11:57 AM

LGTM

zibi added a comment.Apr 10 2023, 10:47 AM

This is already reviewed and accepted but blocked by libc++abi group.
Can I have somebody from libc++abi to have a peek at this patch?

zibi added a comment.Apr 19 2023, 5:09 AM

Ping, can I can the approval?
This is a minor patch which should not take to loog.

phosek accepted this revision.Apr 20 2023, 8:15 PM

LGTM

SeanP accepted this revision.Apr 21 2023, 6:41 AM

LGTM

This revision is now accepted and ready to land.Apr 21 2023, 6:41 AM
This revision was landed with ongoing or failed builds.Apr 21 2023, 9:36 AM
This revision was automatically updated to reflect the committed changes.