This is an archive of the discontinued LLVM Phabricator instance.

[asan][test][win] Make report_after_syminitialize test less brittle
ClosedPublic

Authored by alvinhochun on Apr 1 2023, 11:21 AM.

Details

Summary

Instead of relying on one of the two commands failing on MinGW target,
just use the %if conditional substitution feature from lit, which is
much less brittle.

Amends 5888a47914f44ffaf102fcb7afd3500706fe753f

Diff Detail

Event Timeline

alvinhochun created this revision.Apr 1 2023, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2023, 11:21 AM
Herald added a subscriber: Enna1. · View Herald Transcript
alvinhochun requested review of this revision.Apr 1 2023, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2023, 11:21 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mstorsjo accepted this revision.Apr 1 2023, 1:26 PM

LGTM, thanks, this makes it much nicer indeed!

This revision is now accepted and ready to land.Apr 1 2023, 1:26 PM