This is an archive of the discontinued LLVM Phabricator instance.

[IPO] Add documentation for new function argument
ClosedPublic

Authored by smeenai on Mar 29 2023, 3:27 AM.

Diff Detail

Event Timeline

smeenai created this revision.Mar 29 2023, 3:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2023, 3:27 AM
smeenai requested review of this revision.Mar 29 2023, 3:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2023, 3:27 AM
tejohnson accepted this revision.Mar 29 2023, 6:52 AM

Thanks! lgtm with minor wording tweak suggested

llvm/include/llvm/Transforms/IPO/FunctionImport.h
139

Maybe just "callback" instead of "function-like object"?

This revision is now accepted and ready to land.Mar 29 2023, 6:52 AM
smeenai added inline comments.Mar 29 2023, 8:34 AM
llvm/include/llvm/Transforms/IPO/FunctionImport.h
139

Yup, that's the word I was looking for :D

This revision was landed with ongoing or failed builds.Mar 29 2023, 8:37 AM
This revision was automatically updated to reflect the committed changes.