This is an archive of the discontinued LLVM Phabricator instance.

Differential D147030

[Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true
ClosedPublic

Authored by brad on Mar 28 2023, 12:36 AM.

Details

Reviewers
MaskRay
Commits
rGd44371c00d87: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true
Summary

Invert the logic and have the default being true. Disable the few spots where it looks like IAS is currently not used.

Diff Detail

Event Timeline

brad created this revision.Mar 28 2023, 12:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 12:36 AM
Herald added subscribers: s.egerton, simoncook, fedor.sergeev. · View Herald Transcript
brad requested review of this revision.Mar 28 2023, 12:36 AM
Herald added a subscriber: • pcwang-thead. · View Herald TranscriptMar 28 2023, 12:36 AM
Harbormaster completed remote builds in B222177: Diff 508457.Mar 28 2023, 1:11 AM
MaskRay accepted this revision.Mar 28 2023, 10:48 AM
This revision is now accepted and ready to land.Mar 28 2023, 10:48 AM
MaskRay added inline comments.Mar 28 2023, 10:48 AM
clang/lib/Driver/ToolChains/Gnu.cpp
2924

return getTriple().getVendor() != llvm::Triple::Myriad;

brad updated this revision to Diff 509084.Mar 28 2023, 11:35 AM
This revision was landed with ongoing or failed builds.Mar 28 2023, 7:27 PM
Closed by commit rGd44371c00d87: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true (authored by brad). · Explain Why
This revision was automatically updated to reflect the committed changes.
brad added a commit: rGd44371c00d87: [Clang][Driver] Default Generic_GCC::IsIntegratedAssemblerDefault to true.
Harbormaster completed remote builds in B222307: Diff 509084.Mar 28 2023, 8:43 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
42 lines
test/
Driver/
1 line

Diff 509189

clang/lib/Driver/ToolChains/Gnu.cpp

Show First 20 Lines • Show All 2,910 Lines • ▼ Show 20 Lines
} }
bool Generic_GCC::isPICDefaultForced() const { bool Generic_GCC::isPICDefaultForced() const {
return getArch() == llvm::Triple::x86_64 && getTriple().isOSWindows(); return getArch() == llvm::Triple::x86_64 && getTriple().isOSWindows();
} }
bool Generic_GCC::IsIntegratedAssemblerDefault() const { bool Generic_GCC::IsIntegratedAssemblerDefault() const {
switch (getTriple().getArch()) { switch (getTriple().getArch()) {
case llvm::Triple::aarch64: case llvm::Triple::nvptx:
case llvm::Triple::aarch64_be: case llvm::Triple::nvptx64:
case llvm::Triple::amdgcn: case llvm::Triple::xcore:
case llvm::Triple::arm:
case llvm::Triple::armeb:
case llvm::Triple::avr:
case llvm::Triple::bpfel:
case llvm::Triple::bpfeb:
case llvm::Triple::csky:
case llvm::Triple::hexagon:
case llvm::Triple::lanai:
case llvm::Triple::loongarch32:
case llvm::Triple::loongarch64:
case llvm::Triple::m68k:
case llvm::Triple::mips:
case llvm::Triple::mipsel:
case llvm::Triple::mips64:
case llvm::Triple::mips64el:
case llvm::Triple::msp430:
case llvm::Triple::ppc:
case llvm::Triple::ppcle:
case llvm::Triple::ppc64:
case llvm::Triple::ppc64le:
case llvm::Triple::r600:
case llvm::Triple::riscv32:
case llvm::Triple::riscv64:
case llvm::Triple::sparc:
case llvm::Triple::sparcel:
case llvm::Triple::sparcv9:
case llvm::Triple::systemz:
case llvm::Triple::thumb:
case llvm::Triple::thumbeb:
case llvm::Triple::ve:
case llvm::Triple::x86:
case llvm::Triple::x86_64:
return true;
default:
return false; return false;
default:
return getTriple().getVendor() != llvm::Triple::Myriad;
MaskRayUnsubmitted
Not Done
ReplyInline Actions

return getTriple().getVendor() != llvm::Triple::Myriad;

MaskRay: `return getTriple().getVendor() != llvm::Triple::Myriad;`
} }
} }
void Generic_GCC::PushPPaths(ToolChain::path_list &PPaths) { void Generic_GCC::PushPPaths(ToolChain::path_list &PPaths) {
// Cross-compiling binutils and GCC installations (vanilla and openSUSE at // Cross-compiling binutils and GCC installations (vanilla and openSUSE at
// least) put various tools in a triple-prefixed directory off of the parent // least) put various tools in a triple-prefixed directory off of the parent
// of the GCC installation. We use the GCC triple here to ensure that we end // of the GCC installation. We use the GCC triple here to ensure that we end
// up with tools that support the same amount of cross compiling as the // up with tools that support the same amount of cross compiling as the
▲ Show 20 Lines • Show All 316 Lines • Show Last 20 Lines

clang/test/Driver/integrated-as.c

// RUN: %clang -### -c -save-temps -integrated-as %s 2>&1 | FileCheck %s // RUN: %clang -### -c -save-temps -integrated-as %s 2>&1 | FileCheck %s
// CHECK: cc1as // CHECK: cc1as
// CHECK: -mrelax-all // CHECK: -mrelax-all
// RUN: %clang -### -fintegrated-as -c -save-temps %s 2>&1 | FileCheck %s -check-prefix FIAS // RUN: %clang -### -fintegrated-as -c -save-temps %s 2>&1 | FileCheck %s -check-prefix FIAS
// FIAS: cc1as // FIAS: cc1as
// RUN: %clang -target none -### -fno-integrated-as -S %s 2>&1 \ // RUN: %clang -target none -### -fno-integrated-as -S %s 2>&1 \
// RUN: | FileCheck %s -check-prefix NOFIAS // RUN: | FileCheck %s -check-prefix NOFIAS
// NOFIAS-NOT: cc1as // NOFIAS-NOT: cc1as
// NOFIAS: -cc1 // NOFIAS: -cc1
// NOFIAS: "-fno-verbose-asm"
// NOFIAS: -no-integrated-as // NOFIAS: -no-integrated-as