[mlir][sparse] rephrase the documentation for sparse compiler create-sparse-deallocs option.
ClosedPublic
Actions

Authored by Peiming on Mar 27 2023, 4:46 PM.

Details

Reviewers

aartbik
nicolasvasilache
wrengr

Commits

rG36c8a9a9830a: [mlir][sparse] rephrase the documentation for sparse compiler create-sparse…

Summary

To address post-submit comments in https://reviews.llvm.org/D147010.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Peiming created this revision.Mar 27 2023, 4:46 PM

Herald added a reviewer: aartbik. · View Herald TranscriptMar 27 2023, 4:46 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: hanchung, jsetoain, Moerafaat and 23 others. · View Herald Transcript

Peiming requested review of this revision.Mar 27 2023, 4:46 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 27 2023, 4:46 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Peiming added a reviewer: wrengr.Mar 27 2023, 4:47 PM

wrengr added inline comments.Mar 27 2023, 4:49 PM

mlir/include/mlir/Dialect/SparseTensor/Pipelines/Passes.h
82	"buffers"
82	I'd drop this adjective
86–87	I'd leave this part out.

address comments.

Peiming marked 3 inline comments as done.Mar 27 2023, 4:52 PM

wrengr accepted this revision.Mar 27 2023, 4:57 PM

This revision is now accepted and ready to land.Mar 27 2023, 4:57 PM

This revision was landed with ongoing or failed builds.Mar 27 2023, 5:00 PM

Closed by commit rG36c8a9a9830a: [mlir][sparse] rephrase the documentation for sparse compiler create-sparse… (authored by Peiming). · Explain Why

This revision was automatically updated to reflect the committed changes.

Peiming added a commit: rG36c8a9a9830a: [mlir][sparse] rephrase the documentation for sparse compiler create-sparse….

Harbormaster completed remote builds in B222136: Diff 508843.Mar 27 2023, 5:23 PM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

SparseTensor/

Pipelines/

Passes.h

7 lines

Transforms/

Passes.td

7 lines

Diff 508846

View Options

mlir/include/mlir/Dialect/SparseTensor/Pipelines/Passes.h