This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fix an OpenMP Windows build problem

Authored by vadikp-intel on Mar 25 2023, 6:45 PM.



When built as part of LLVM, CMAKE is generating incorrect locations references for the first build step's artifacts being used in regenerating the Windows import library in the second step. The fix is to feed a dummy non-buildable, rather than buildable, source to CMAKE to satisfy its source requirement in the second step removing the need to reference the first step's artifacts.

Diff Detail

Event Timeline

vadikp-intel created this revision.Mar 25 2023, 6:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 6:45 PM
vadikp-intel requested review of this revision.Mar 25 2023, 6:45 PM

Removed redundant comments.

vadikp-intel edited the summary of this revision. (Show Details)
vadikp-intel set the repository for this revision to rG LLVM Github Monorepo.

Updated with a better fix.

mstorsjo accepted this revision.Mar 27 2023, 1:41 PM

LGTM, thanks! This is indeed the neatest solution so far!


Can't we get rid of the omp dependency here at this point too, since there's no technical need to build it after the main library has been built?

This revision is now accepted and ready to land.Mar 27 2023, 1:41 PM

removed a now redundant dependency

vadikp-intel marked an inline comment as done.Mar 27 2023, 4:58 PM
This revision was automatically updated to reflect the committed changes.