This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Do nothing when sinking to same place
ClosedPublic

Authored by aheejin on Mar 24 2023, 6:41 PM.

Details

Summary

In DebugValueManager, if a Def is requested to be sunk to the same
place (i.e., Insert is right after Def, not counting DBG_VALUEs)
currently we still do the sink. This can result in unnecessary creation
of DBG_VALUE $noreg. See comments for details. This CL detects this
case and do nothing and return, so we don't end up creating unnecessary
undef DBG_VALUEs.

Diff Detail

Event Timeline

aheejin created this revision.Mar 24 2023, 6:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 6:41 PM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
aheejin requested review of this revision.Mar 24 2023, 6:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 6:41 PM
dschuff accepted this revision.Mar 27 2023, 7:59 AM
This revision is now accepted and ready to land.Mar 27 2023, 7:59 AM
This revision was landed with ongoing or failed builds.Mar 29 2023, 12:51 PM
This revision was automatically updated to reflect the committed changes.