[support] Temporarily disable Inf/NaN testing in PrintNumber

[paulkirth]

Summary

This is still breaking on some platforms. The underlying implementation
doesn't seem to be the cause, rather the test is not robust across
platforms. So, we'll just disable this for the time being, to unblock
builds until we have a proper fix.

[paulkirth]

clang-format

[abhina.sreeskantharajan]

Would it be better to remove the lines and just leave the FIXME comments? I don't know if leaving commented out code is good style, but please correct me if I'm wrong and this is done elsewhere

[paulkirth]

Remove most commented out code. Specifically leaving the PrintNumber ones, since they are clear about what should be re-enabled.

[abhina.sreeskantharajan]

LGTM

[abhina.sreeskantharajan]

llvm/unittests/Support/ScopedPrinterTest.cpp

669

nit: looks like a formatting issue here

[paulkirth]

git clang-format HEAD~ formatted it that way

llvm/unittests/Support/ScopedPrinterTest.cpp

auto PrintFunc = [&](ScopedPrinter &W) {
 
     APSInt LargeNum("9999999999999999999999");
     W.printNumber("apsint", LargeNum);
 
     W.printNumber("label", "value", 0);
 
     W.printNumber("float-max", MaxFloat);
     W.printNumber("float-min", MinFloat);
-    W.printNumber("float-inf", InfFloat);
-    W.printNumber("float-nan", NaNFloat);
     W.printNumber("float-42.0", 42.0f);
     W.printNumber("float-42.5625", 42.5625f);
 
     W.printNumber("double-max", MaxDouble);
     W.printNumber("double-min", MinDouble);
-    W.printNumber("double-inf", InfDouble);
-    W.printNumber("double-nan", NaNDouble);
     W.printNumber("double-42.0", 42.0);
     W.printNumber("double-42.5625", 42.5625);
+
+    // FIXME: temporarily disable checking the for Inf and NaN until we have a
+    // cross platform solution can handle this case
+    // W.printNumber("float-inf", InfFloat);
+    // W.printNumber("float-nan", NaNFloat);
+    // W.printNumber("double-inf", InfDouble);
+    // W.printNumber("double-nan", NaNDouble);
   };
 
   // Make sure when we check floating point representation we avoid
   // implementation defined behavior. So format the max float/double, instead of
   // hard coding it in the tests. Note: we can't just use std::to_string(),
   // since we format the float in PrintNumber(). This isn't required for JSON
   // formatting, since it uses exponents, which will be consistent. However,
   // NaN and INF may be printed differently, (like AIX), so we still need to 
   // handle those cases for JSON checking.
 
   // Allocate a buffer large enough to represent large floating point values
   // and construct the string representation for them there.
   char Buf[512];
 
   format("%5.1f", MaxFloat).snprint(Buf, sizeof(Buf));
   std::string MaxFloatStr(Buf);
 
   format("%5.1f", MaxDouble).snprint(Buf, sizeof(Buf));
   std::string MaxDoubleStr(Buf);
 
-  format("%5.1f", InfFloat).snprint(Buf, sizeof(Buf));
-  std::string InfFloatStr(Buf);
-
-  format("%5.1f", InfDouble).snprint(Buf, sizeof(Buf));
-  std::string InfDoubleStr(Buf);
-
-  format("%5.1f", NaNFloat).snprint(Buf, sizeof(Buf));
-  std::string NaNFloatStr(Buf);
-
-  format("%5.1f", NaNDouble).snprint(Buf, sizeof(Buf));
-  std::string NaNDoubleStr(Buf);
-
-  format("%.*g", InfFloat).snprint(Buf, sizeof(Buf));
-  std::string JsonInfFloatStr(Buf);
-
-  format("%.*g", InfDouble).snprint(Buf, sizeof(Buf));
-  std::string JsonInfDoubleStr(Buf);
-
-  format("%.*g", NaNFloat).snprint(Buf, sizeof(Buf));
-  std::string JsonNaNFloatStr(Buf);
-
-  format("%.*g", NaNDouble).snprint(Buf, sizeof(Buf));
-  std::string JsonNaNDoubleStr(Buf);
-
+  // FIXME: temporarily disable checking the for Inf and NaN until we have a
+  // cross platform solution can handle this case
 
   std::string ExpectedOut = Twine(
                                 R"(uint64_t-max: 18446744073709551615
 uint64_t-min: 0
 uint32_t-max: 4294967295
 uint32_t-min: 0
 uint16_t-max: 65535
 uint16_t-min: 0
 uint8_t-max: 255
 uint8_t-min: 0
 int64_t-max: 9223372036854775807
 int64_t-min: -9223372036854775808
 int32_t-max: 2147483647
 int32_t-min: -2147483648
 int16_t-max: 32767
 int16_t-min: -32768
 int8_t-max: 127
 int8_t-min: -128
 apsint: 9999999999999999999999
 label: value (0)
 float-max: )" + MaxFloatStr + R"(
 float-min:   0.0
-float-inf: )" + InfFloatStr + R"(
-float-nan: )" + NaNFloatStr + R"(
 float-42.0:  42.0
 float-42.5625:  42.6
 double-max: )" + MaxDoubleStr +
                                 R"(
 double-min:   0.0
-double-inf: )" + InfDoubleStr + R"(
-double-nan: )" + NaNDoubleStr + R"(
 double-42.0:  42.0
 double-42.5625:  42.6
 )")
                                 .str();
 
   std::string JSONExpectedOut = Twine(R"({
   "uint64_t-max": 18446744073709551615,
   "uint64_t-min": 0,
)")
   "int8_t-min": -128,
   "apsint": 9999999999999999999999,
   "label": {
     "Name": "value",
     "Value": 0
   },
   "float-max": 3.4028234663852886e+38,
   "float-min": 1.1754943508222875e-38,
-  "float-inf": )" + JsonInfFloatStr + R"(,
-  "float-nan": )" + JsonNaNFloatStr + R"(,
   "float-42.0": 42,
   "float-42.5625": 42.5625,
   "double-max": 1.7976931348623157e+308,
   "double-min": 2.2250738585072014e-308,
-  "double-inf": )" + JsonInfDoubleStr + R"(,
-  "double-nan": )" + JsonNaNDoubleStr + R"(,
   "double-42.0": 42,
   "double-42.5625": 42.5625
-})").str();
+})")
+                                    .str();
   verifyAll(ExpectedOut, JSONExpectedOut, PrintFunc);
 }
 
 TEST_F(ScopedPrinterTest, PrintBoolean) {
   auto PrintFunc = [](ScopedPrinter &W) {
     W.printBoolean("True", true);
     W.printBoolean("False", false);
   };