This is an archive of the discontinued LLVM Phabricator instance.

Differential D146756

[Sanitizers] Fix a memory leak
ClosedPublic

Authored by cchen15 on Mar 23 2023, 1:30 PM.

Details

Reviewers
kcc
vitalybuka
MaskRay
Commits
rG5aef3dfad685: [Sanitizers] Fix a memory leak.

Diff Detail

Event Timeline

cchen15 created this revision.Mar 23 2023, 1:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 1:30 PM
Herald added a subscriber: Enna1. · View Herald Transcript
cchen15 requested review of this revision.Mar 23 2023, 1:30 PM
cchen15 added a reviewer: samsonov.Mar 23 2023, 1:33 PM
Harbormaster completed remote builds in B221402: Diff 507859.Mar 23 2023, 1:49 PM
cchen15 edited reviewers, added: kcc, vitalybuka; removed: samsonov.Mar 24 2023, 10:46 AM
vitalybuka accepted this revision.Mar 27 2023, 11:26 AM
This revision is now accepted and ready to land.Mar 27 2023, 11:26 AM
MaskRay accepted this revision.Mar 27 2023, 12:06 PM
MaskRay added a subscriber: MaskRay.

LGTM. A successful ReadFileToBuffer call called MmapOrDie which needs a pairing UnmapOrDie.

Closed by commit rG5aef3dfad685: [Sanitizers] Fix a memory leak. (authored by cchen15). · Explain WhyMar 28 2023, 5:49 AM
This revision was automatically updated to reflect the committed changes.
cchen15 added a commit: rG5aef3dfad685: [Sanitizers] Fix a memory leak..
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 28 2023, 5:49 AM

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
1 line

Diff 507859

compiler-rt/lib/sanitizer_common/sanitizer_suppressions.cpp

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Linesvoid SuppressionContext::ParseFromFile(const char *filename) {
if (!ReadFileToBuffer(filename, &file_contents, &buffer_size, if (!ReadFileToBuffer(filename, &file_contents, &buffer_size,
&contents_size)) { &contents_size)) {
Printf("%s: failed to read suppressions file '%s'\n", SanitizerToolName, Printf("%s: failed to read suppressions file '%s'\n", SanitizerToolName,
filename); filename);
Die(); Die();
} }
Parse(file_contents); Parse(file_contents);
UnmapOrDie(file_contents, contents_size);
} }
bool SuppressionContext::Match(const char *str, const char *type, bool SuppressionContext::Match(const char *str, const char *type,
Suppression **s) { Suppression **s) {
can_parse_ = false; can_parse_ = false;
if (!HasSuppressionType(type)) if (!HasSuppressionType(type))
return false; return false;
for (uptr i = 0; i < suppressions_.size(); i++) { for (uptr i = 0; i < suppressions_.size(); i++) {
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines