This is an archive of the discontinued LLVM Phabricator instance.

[extract_symbols.py] Export unique symbols
ClosedPublic

Authored by tmatheson on Mar 23 2023, 9:15 AM.

Details

Summary

As described in a comment on D140637, PluginInlineOrderTest.NoInlineFoo
will fail with:

InlineOrderPlugin.so: undefined symbol: _ZN4llvm13AllAnalysesOnINS_6ModuleEE6SetKeyE

The symbol is unique in libLLVMCore and ends up local in AnalysisTests.
Fix this by exporting all unique symbols found in libraries.

AnalysisTests.symbols change in line count: 12464 -> 12499

Diff Detail

Event Timeline

tmatheson created this revision.Mar 23 2023, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 9:15 AM
tmatheson requested review of this revision.Mar 23 2023, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 9:15 AM
simon_tatham accepted this revision.Mar 24 2023, 7:44 AM
This revision is now accepted and ready to land.Mar 24 2023, 7:44 AM
This revision was automatically updated to reflect the committed changes.