This is an archive of the discontinued LLVM Phabricator instance.

Differential D146689

[OpenMP] Add notifyDataUnmapped back in disassociatePtr
ClosedPublic

Authored by ye-luo on Mar 22 2023, 10:17 PM.

Details

Reviewers
jdoerfert
tianshilei1992
Commits
rG3ab79124db5e: [OpenMP] Add notifyDataUnmapped back in disassociatePtr
Summary

Fix regression introduced by https://reviews.llvm.org/D123446

Diff Detail

Event Timeline

ye-luo created this revision.Mar 22 2023, 10:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 10:17 PM
Herald added subscribers: sunshaoce, guansong, yaxunl. · View Herald Transcript
ye-luo requested review of this revision.Mar 22 2023, 10:17 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMar 22 2023, 10:17 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, jplehr, sstefan1. · View Herald Transcript
ye-luo retitled this revision from [OpenMP] Add notifyDataUnmapped bacl in disassociatePtr to [OpenMP] Add notifyDataUnmapped back in disassociatePtr.Mar 22 2023, 10:19 PM
Harbormaster completed remote builds in B221221: Diff 507608.Mar 22 2023, 10:20 PM
tianshilei1992 accepted this revision.Mar 23 2023, 6:32 AM
tianshilei1992 added a subscriber: tianshilei1992.

LG

This revision is now accepted and ready to land.Mar 23 2023, 6:32 AM
Closed by commit rG3ab79124db5e: [OpenMP] Add notifyDataUnmapped back in disassociatePtr (authored by ye-luo). · Explain WhyMar 23 2023, 6:58 AM
This revision was automatically updated to reflect the committed changes.
ye-luo added a commit: rG3ab79124db5e: [OpenMP] Add notifyDataUnmapped back in disassociatePtr.

Revision Contents

PathSize
openmp/
libomptarget/
src/
2 lines

Diff 507730

openmp/libomptarget/src/device.cpp

Show First 20 Lines • Show All 128 Lines • ▼ Show 20 Linesint DeviceTy::disassociatePtr(void *HstPtrBegin) {
if (HDTT.isDynRefCountInf()) { if (HDTT.isDynRefCountInf()) {
DP("Association found, removing it\n"); DP("Association found, removing it\n");
void *Event = HDTT.getEvent(); void *Event = HDTT.getEvent();
delete &HDTT; delete &HDTT;
if (Event) if (Event)
destroyEvent(Event); destroyEvent(Event);
HDTTMap->erase(It); HDTTMap->erase(It);
return OFFLOAD_SUCCESS; return notifyDataUnmapped(HstPtrBegin);
} }
REPORT("Trying to disassociate a pointer which was not mapped via " REPORT("Trying to disassociate a pointer which was not mapped via "
"omp_target_associate_ptr\n"); "omp_target_associate_ptr\n");
return OFFLOAD_FAIL; return OFFLOAD_FAIL;
} }
LookupResult DeviceTy::lookupMapping(HDTTMapAccessorTy &HDTTMap, LookupResult DeviceTy::lookupMapping(HDTTMapAccessorTy &HDTTMap,
▲ Show 20 Lines • Show All 615 Lines • Show Last 20 Lines