Added a new analysis pass that allows collecting context information
about instructions and basic blocks. This analysis will help to give more
meaningful names for instructions and basic blocks in the MetaRenamer pass.
Also, this pass collects the full context for the given instruction/basic block.
Details
Details
- Reviewers
mkazantsev apilipenko
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I don't think a separate analysis is justified here. If you want to improve the meta renamer just make the necessary changes there.
I'm not sure why you need "Context" info for meta renames.
Comment Actions
Actually it was I who proposed Dmitry to split it off into a separate analysis. The main advantage of this approach is that we can then create some static analysis tools that don't necessarily modify the IR to give you the same info.
Comment Actions
I think it would still be preferable to start implementing this as a MetaRenamer improvement, and then extracting it into a separate analysis if we have an actual use case for it.
Comment Actions
Marking to remove it from my review list, please update if you have plans on it. Let's start from MetaRenamer changes.
StringRef (here and everywhere)