Page MenuHomePhabricator
Differential D146381

[mlir] Support bufferization of arith.constant to memref.global with memory space
ClosedPublic
Actions

Authored by mamrami on Mar 19 2023, 7:32 AM.

Details

Reviewers
nicolasvasilache
springerm
Commits
rG8bb5ca58327e: [mlir] Support bufferization of arith.constant to memref.global with memory…

Diff Detail

Event Timeline

mamrami created this revision.Mar 19 2023, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2023, 7:32 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 21 others. · View Herald Transcript
mamrami requested review of this revision.Mar 19 2023, 7:32 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 19 2023, 7:32 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mamrami added a reviewer: springerm.Mar 19 2023, 7:34 AM
Harbormaster completed remote builds in B220295: Diff 506394.Mar 19 2023, 7:49 AM
mamrami updated this revision to Diff 506520.Mar 20 2023, 3:24 AM

rebase

Harbormaster completed remote builds in B220393: Diff 506520.Mar 20 2023, 3:45 AM
mamrami updated this revision to Diff 506569.Mar 20 2023, 7:16 AM

Fix bug

springerm accepted this revision.Mar 20 2023, 7:21 AM
springerm added inline comments.
mlir/include/mlir/Dialect/Bufferization/Transforms/BufferUtils.h
129

nit: Can we make this optional: Attribute memorySpace = {}

This revision is now accepted and ready to land.Mar 20 2023, 7:21 AM
Harbormaster completed remote builds in B220428: Diff 506569.Mar 20 2023, 7:33 AM
mamrami updated this revision to Diff 506582.Mar 20 2023, 7:38 AM

CR fix

mamrami marked an inline comment as done.Mar 20 2023, 7:40 AM
Harbormaster completed remote builds in B220438: Diff 506582.Mar 20 2023, 8:02 AM
Closed by commit rG8bb5ca58327e: [mlir] Support bufferization of arith.constant to memref.global with memory… (authored by mamrami). · Explain WhyMar 20 2023, 8:10 AM
This revision was automatically updated to reflect the committed changes.
mamrami added a commit: rG8bb5ca58327e: [mlir] Support bufferization of arith.constant to memref.global with memory….

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Bufferization/
Transforms/
3 lines
lib/
Dialect/
Arith/
Transforms/
12 lines
Bufferization/
Transforms/
7 lines
test/
Dialect/
Arith/
4 lines

Diff 506569

View Options

mlir/include/mlir/Dialect/Bufferization/Transforms/BufferUtils.h

Loading...
View Options

mlir/lib/Dialect/Arith/Transforms/BufferizableOpInterfaceImpl.cpp

Loading...
View Options

mlir/lib/Dialect/Bufferization/Transforms/BufferUtils.cpp

Loading...
View Options

mlir/test/Dialect/Arith/one-shot-bufferize-memory-space-invalid.mlir

Loading...