mul into selects.
Needs RevisionPublic
Actions

Authored by goldstein.w.n on Fri, Mar 17, 7:05 PM.

Details

Reviewers

nikic
spatel
majnemer

Summary

Don't only do constant cases, also try cases were we can't constant
fold both sides. In the same we can't constant fold both sides, only
do transform if the select is single use.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

goldstein.w.n created this revision.Fri, Mar 17, 7:05 PM

Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 7:05 PM

Herald added a subscriber: hiraditya. · View Herald Transcript

goldstein.w.n requested review of this revision.Fri, Mar 17, 7:05 PM

Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 7:05 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B220194: Diff 506260.Fri, Mar 17, 7:06 PM

goldstein.w.n added a parent revision: D146348: [InstCombine] Add more tests for folding irem/idiv/mul with select; NFC.Fri, Mar 17, 7:07 PM

goldstein.w.n added reviewers: nikic, spatel, majnemer.

Herald added a subscriber: StephenFan. · View Herald TranscriptFri, Mar 17, 7:07 PM

Rebase

Harbormaster completed remote builds in B220252: Diff 506331.Sat, Mar 18, 2:42 PM

This is not generally legal for div/rem, see https://alive2.llvm.org/ce/z/2iiR26 using one of your tests. This is only legal if the operation is speculatable.

This revision now requires changes to proceed.Sat, Mar 18, 3:03 PM