Page MenuHomePhabricator

[clang] Include the error message in file reading error diagnostic
ClosedPublic

Authored by hans on Fri, Mar 17, 3:05 AM.

Details

Summary

in order to provide as much information as possible to the user. The diagnostic will now look like for example:

error: error reading '/tmp/foo.c': Permission denied

(This addresses a FIXME from 2019, 9ef6c49baf45)

Diff Detail

Event Timeline

hans created this revision.Fri, Mar 17, 3:05 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFri, Mar 17, 3:05 AM
hans requested review of this revision.Fri, Mar 17, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 3:05 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
thakis accepted this revision.Fri, Mar 17, 3:59 AM
thakis added a subscriber: thakis.

Lg

This revision is now accepted and ready to land.Fri, Mar 17, 3:59 AM

(if the presubmit is related, maybe some flang test needs updating? Weird that flang uses clang's diags.)

hans added a comment.Fri, Mar 17, 5:47 AM

(if the presubmit is related, maybe some flang test needs updating? Weird that flang uses clang's diags.)

The presubmit errors look unrelated and the flang tests seem fine locally.

This revision was landed with ongoing or failed builds.Fri, Mar 17, 5:48 AM
This revision was automatically updated to reflect the committed changes.