This is an archive of the discontinued LLVM Phabricator instance.

Differential D146240

[libc++][format] Use granularized charconv.
ClosedPublic

Authored by Mordante on Mar 16 2023, 10:00 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG57e20cab5a1d: [libc++][format] Use granularized charconv.
Summary

This reduces the number of transitive includes when using format.

Diff Detail

Event Timeline

Mordante created this revision.Mar 16 2023, 10:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 10:00 AM
Herald added a subscriber: mikhail.ramalho. · View Herald Transcript
Mordante requested review of this revision.Mar 16 2023, 10:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 10:00 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B219905: Diff 505855.Mar 16 2023, 10:24 AM
Mordante updated this revision to Diff 505870.Mar 16 2023, 10:30 AM

CI fixes.

Harbormaster completed remote builds in B219916: Diff 505870.Mar 16 2023, 11:09 AM
Mordante updated this revision to Diff 505887.Mar 16 2023, 11:26 AM

CI fixes.

Harbormaster completed remote builds in B219926: Diff 505887.Mar 16 2023, 12:50 PM
Mordante updated this revision to Diff 506174.Mar 17 2023, 12:21 PM

CI fixes.

Harbormaster completed remote builds in B220129: Diff 506174.Mar 17 2023, 1:42 PM
Mordante mentioned this in D146395: [libc++] Move __errc to __system_error/errc.h.Mar 20 2023, 10:40 AM
ldionne accepted this revision.Mar 28 2023, 8:36 AM
This revision is now accepted and ready to land.Mar 28 2023, 8:36 AM
This revision was landed with ongoing or failed builds.Apr 7 2023, 8:49 AM
Closed by commit rG57e20cab5a1d: [libc++][format] Use granularized charconv. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG57e20cab5a1d: [libc++][format] Use granularized charconv..
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 7 2023, 8:49 AM
Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. · View Herald Transcript
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan removed a project: Restricted Project.Apr 7 2023, 11:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2023, 11:35 AM
owenpan removed a reviewer: owenpan.Apr 7 2023, 11:35 AM
Herald added a reviewer: owenpan. · View Herald TranscriptApr 7 2023, 11:35 AM
NOTE: Clang-Format Team Automated Review Comment

It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an NFC or refactoring, adding documentation etc..)

Add your unit tests in clang/unittests/Format and you can build with ninja FormatTests. We recommend using the verifyFormat(xxx) format of unit tests rather than EXPECT_EQ as this will ensure you change is tolerant to random whitespace changes (see FormatTest.cpp as an example)

For situations where your change is altering the TokenAnnotator.cpp which can happen if you are trying to improve the annotation phase to ensure we are correctly identifying the type of a token, please add a token annotator test in TokenAnnotatorTest.cpp

MyDeveloperDay removed reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay, owenpan.Apr 13 2023, 6:50 AM
MyDeveloperDay removed a project: Restricted Project.

Revision Contents

PathSize
libcxx/
include/
__format/
7 lines
5 lines
4 lines
4 lines
test/
libcxx/
transitive_includes/
2 lines
2 lines
2 lines
2 lines
2 lines
3 lines

Diff 511699

libcxx/include/__format/formatter_floating_point.h

Show All 10 Lines
#define _LIBCPP___FORMAT_FORMATTER_FLOATING_POINT_H #define _LIBCPP___FORMAT_FORMATTER_FLOATING_POINT_H
#include <__algorithm/copy_n.h> #include <__algorithm/copy_n.h>
#include <__algorithm/find.h> #include <__algorithm/find.h>
#include <__algorithm/max.h> #include <__algorithm/max.h>
#include <__algorithm/min.h> #include <__algorithm/min.h>
#include <__algorithm/rotate.h> #include <__algorithm/rotate.h>
#include <__algorithm/transform.h> #include <__algorithm/transform.h>
#include <__charconv/chars_format.h>
#include <__charconv/to_chars_floating_point.h>
#include <__charconv/to_chars_result.h>
#include <__concepts/arithmetic.h> #include <__concepts/arithmetic.h>
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__config> #include <__config>
#include <__errc>
#include <__format/concepts.h> #include <__format/concepts.h>
#include <__format/format_parse_context.h> #include <__format/format_parse_context.h>
#include <__format/formatter.h> #include <__format/formatter.h>
#include <__format/formatter_integral.h> #include <__format/formatter_integral.h>
#include <__format/formatter_output.h> #include <__format/formatter_output.h>
#include <__format/parser_std_format_spec.h> #include <__format/parser_std_format_spec.h>
#include <__memory/allocator.h> #include <__memory/allocator.h>
#include <__type_traits/conditional.h> #include <__type_traits/conditional.h>
#include <__utility/move.h> #include <__utility/move.h>
#include <__utility/unreachable.h> #include <__utility/unreachable.h>
#include <charconv> #include <cmath>
#include <cstddef>
#ifndef _LIBCPP_HAS_NO_LOCALIZATION #ifndef _LIBCPP_HAS_NO_LOCALIZATION
# include <locale> # include <locale>
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
▲ Show 20 Lines • Show All 717 Lines • Show Last 20 Lines

libcxx/include/__format/formatter_integral.h

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___FORMAT_FORMATTER_INTEGRAL_H #ifndef _LIBCPP___FORMAT_FORMATTER_INTEGRAL_H
#define _LIBCPP___FORMAT_FORMATTER_INTEGRAL_H #define _LIBCPP___FORMAT_FORMATTER_INTEGRAL_H
#include <__charconv/to_chars_integral.h>
#include <__charconv/to_chars_result.h>
#include <__charconv/traits.h>
#include <__concepts/arithmetic.h> #include <__concepts/arithmetic.h>
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__config> #include <__config>
#include <__errc>
#include <__format/concepts.h> #include <__format/concepts.h>
#include <__format/format_error.h> #include <__format/format_error.h>
#include <__format/formatter_output.h> #include <__format/formatter_output.h>
#include <__format/parser_std_format_spec.h> #include <__format/parser_std_format_spec.h>
#include <__type_traits/make_unsigned.h> #include <__type_traits/make_unsigned.h>
#include <__utility/unreachable.h> #include <__utility/unreachable.h>
#include <array> #include <array>
#include <charconv>
#include <limits> #include <limits>
#include <string> #include <string>
#include <string_view> #include <string_view>
#ifndef _LIBCPP_HAS_NO_LOCALIZATION #ifndef _LIBCPP_HAS_NO_LOCALIZATION
# include <locale> # include <locale>
#endif #endif
▲ Show 20 Lines • Show All 334 Lines • Show Last 20 Lines

libcxx/include/__format/formatter_output.h

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___FORMAT_FORMATTER_OUTPUT_H #ifndef _LIBCPP___FORMAT_FORMATTER_OUTPUT_H
#define _LIBCPP___FORMAT_FORMATTER_OUTPUT_H #define _LIBCPP___FORMAT_FORMATTER_OUTPUT_H
#include <__algorithm/ranges_copy.h> #include <__algorithm/ranges_copy.h>
#include <__algorithm/ranges_fill_n.h> #include <__algorithm/ranges_fill_n.h>
#include <__algorithm/ranges_for_each.h> #include <__algorithm/ranges_for_each.h>
#include <__algorithm/ranges_transform.h> #include <__algorithm/ranges_transform.h>
#include <__charconv/to_chars_integral.h>
#include <__charconv/to_chars_result.h>
#include <__chrono/statically_widen.h> #include <__chrono/statically_widen.h>
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__config> #include <__config>
#include <__errc>
#include <__format/buffer.h> #include <__format/buffer.h>
#include <__format/concepts.h> #include <__format/concepts.h>
#include <__format/escaped_output_table.h> #include <__format/escaped_output_table.h>
#include <__format/formatter.h> #include <__format/formatter.h>
#include <__format/parser_std_format_spec.h> #include <__format/parser_std_format_spec.h>
#include <__format/unicode.h> #include <__format/unicode.h>
#include <__iterator/back_insert_iterator.h> #include <__iterator/back_insert_iterator.h>
#include <__iterator/concepts.h> #include <__iterator/concepts.h>
#include <__iterator/readable_traits.h> // iter_value_t #include <__iterator/readable_traits.h> // iter_value_t
#include <__type_traits/make_unsigned.h> #include <__type_traits/make_unsigned.h>
#include <__utility/move.h> #include <__utility/move.h>
#include <__utility/unreachable.h> #include <__utility/unreachable.h>
#include <charconv>
#include <cstddef> #include <cstddef>
#include <string> #include <string>
#include <string_view> #include <string_view>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
▲ Show 20 Lines • Show All 514 Lines • Show Last 20 Lines

libcxx/include/chrono

Show First 20 Lines • Show All 791 Lines • ▼ Show 20 Lines
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <bit> # include <bit>
# include <concepts> # include <concepts>
# include <cstring> # include <cstring>
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER == 20
# include <charconv>
#endif
#endif // _LIBCPP_CHRONO #endif // _LIBCPP_CHRONO

libcxx/test/libcxx/transitive_includes/cxx03.csv

Show First 20 Lines • Show All 311 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format charconv format cmath
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format initializer_list format initializer_list
format limits format limits
format locale format locale
format optional format optional
format queue format queue
▲ Show 20 Lines • Show All 629 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx11.csv

Show First 20 Lines • Show All 311 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format charconv format cmath
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format initializer_list format initializer_list
format limits format limits
format locale format locale
format optional format optional
format queue format queue
▲ Show 20 Lines • Show All 630 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx14.csv

Show First 20 Lines • Show All 313 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format charconv format cmath
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format initializer_list format initializer_list
format limits format limits
format locale format locale
format optional format optional
format queue format queue
▲ Show 20 Lines • Show All 630 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx17.csv

Show First 20 Lines • Show All 313 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format charconv format cmath
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format initializer_list format initializer_list
format limits format limits
format locale format locale
format optional format optional
format queue format queue
▲ Show 20 Lines • Show All 630 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx20.csv

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format charconv format cmath
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format initializer_list format initializer_list
format limits format limits
format locale format locale
format optional format optional
format queue format queue
▲ Show 20 Lines • Show All 628 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b.csv

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines
charconv cerrno charconv cerrno
charconv cmath charconv cmath
charconv cstddef charconv cstddef
charconv cstdint charconv cstdint
charconv cstdlib charconv cstdlib
charconv initializer_list charconv initializer_list
charconv limits charconv limits
chrono array chrono array
chrono charconv
chrono cmath chrono cmath
chrono compare chrono compare
chrono cstddef chrono cstddef
chrono cstdint chrono cstdint
chrono cstdlib chrono cstdlib
chrono ctime chrono ctime
chrono initializer_list chrono initializer_list
chrono limits chrono limits
▲ Show 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
filesystem locale filesystem locale
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem version filesystem version
format array format array
format charconv format cmath
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format initializer_list format initializer_list
format limits format limits
format locale format locale
format optional format optional
format queue format queue
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines