[flang] Fix build error caused by missing llvm-readelf

[sunshaoce]

Summary

Fix build error in D145883. Thanks @awarzynski!

[awarzynski]

Thanks! Would replacing llvm-readelf -h with llvm-objdump -f also work? I'd rather avoid new dependencies if possible.

[sunshaoce]

In D146204#4198779, @awarzynski wrote:

Thanks! Would replacing llvm-readelf -h with llvm-objdump -f also work? I'd rather avoid new dependencies if possible.

I tried, but it didn't print information about Flags.

$ bin/flang-new --target=riscv64-unknown-linux-gnu -c hello.f90 ; bin/llvm-objdump -f hello.o

hello.o:        file format elf64-littleriscv
architecture: riscv64
start address: 0x0000000000000000

[awarzynski]

Thanks for checking - something for a TODO list!

[DavidSpickett]

The standalone build didn't like this, https://github.com/llvm/llvm-project/commit/0b958fe41182c9040499e629e24cbdd250d73bf7 fixes that.

[sunshaoce]

In D146204#4199888, @DavidSpickett wrote:

The standalone build didn't like this, https://github.com/llvm/llvm-project/commit/0b958fe41182c9040499e629e24cbdd250d73bf7 fixes that.

Thanks for fixing!

[clementval]

I still see error in the pre commit CI -> https://buildkite.com/llvm-project/premerge-checks/builds/141680#0186ef93-ff26-4149-bb7d-10163ef64ec5

[DavidSpickett]

Likely the symlink isn't present, somehow. I did worry that this might happen.

I will change the tests to use readobj instead, for want of a proper cmake fix to copy the symlink over.

[DavidSpickett]

https://github.com/llvm/llvm-project/commit/9f93b71f20eaa0e480ce1a184c40b27dd86576d9

[sunshaoce]

In D146204#4202377, @DavidSpickett wrote:

https://github.com/llvm/llvm-project/commit/9f93b71f20eaa0e480ce1a184c40b27dd86576d9

You need to modify the CHECK in code-gen-rv64.f90. I‘ve already commented in https://reviews.llvm.org/rG9f93b71f20ea

flang/test/CMakeLists.txt

set(FLANG_TEST_DEPENDS
   count
   not
   module_files
   fir-opt
   tco
   bbc
   llvm-dis
   llvm-objdump
+  llvm-readelf
   split-file
   FortranRuntime
   Fortran_main
   FortranDecimal
 )
 if (LLVM_ENABLE_PLUGINS AND NOT WIN32)
   list(APPEND FLANG_TEST_DEPENDS Bye)
 endif()